-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cleanup)!: Remove teeny-request in favor of gaxios / authclient #2498
base: gaxios-feature
Are you sure you want to change the base?
Conversation
Attempt 2: this time with less breaking changes. Most of the changes here are removing the old teeny-request and authentication workflows and interfaces in favor of utilizing storage-transport and authclient / gaxios. |
Next milestone: get it compiling |
This is the way! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid. returning GaxiosError instead of APIError seems like the only breaking change?
@danielduhh there are a few but most of them are moving from teeny-request types to Gaxios types (like GaxiosError that you pointed out). I have not touched the publicly exposed API surfaces. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕