Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup)!: Remove teeny-request in favor of gaxios / authclient #2498

Draft
wants to merge 19 commits into
base: gaxios-feature
Choose a base branch
from

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: storage Issues related to the googleapis/nodejs-storage API. labels Jul 9, 2024
@ddelgrosso1 ddelgrosso1 changed the title chore(deps)!: Remove teeny-request in favor of Gaxios / AuthClient chore(cleanup)!: Remove teeny-request in favor of Gaxios / AuthClient Jul 9, 2024
@ddelgrosso1 ddelgrosso1 changed the title chore(cleanup)!: Remove teeny-request in favor of Gaxios / AuthClient chore(cleanup)!: Remove teeny-request in favor of gaxios / authclient Jul 9, 2024
@ddelgrosso1
Copy link
Contributor Author

Attempt 2: this time with less breaking changes. Most of the changes here are removing the old teeny-request and authentication workflows and interfaces in favor of utilizing storage-transport and authclient / gaxios.

@ddelgrosso1
Copy link
Contributor Author

Next milestone: get it compiling

@mindrunner
Copy link

This is the way!

Copy link

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. returning GaxiosError instead of APIError seems like the only breaking change?

@ddelgrosso1
Copy link
Contributor Author

@danielduhh there are a few but most of them are moving from teeny-request types to Gaxios types (like GaxiosError that you pointed out). I have not touched the publicly exposed API surfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants