Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

fix: package name was not set correctly in synth.py #6

Merged
merged 1 commit into from
Jan 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nycrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"**/scripts",
"**/protos",
"**/test",
"**/*.d.ts",
".jsdoc.js",
"**/.jsdoc.js",
"karma.conf.js",
Expand Down
2 changes: 1 addition & 1 deletion protos/protos.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019 Google LLC
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion protos/protos.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019 Google LLC
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
6 changes: 3 additions & 3 deletions src/v1alpha1/workflows_client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ export class WorkflowsClient {
for (const methodName of workflowsStubMethods) {
const innerCallPromise = this.workflowsStub.then(
stub => (...args: Array<{}>) => {
if (this._terminated) {
return Promise.reject('The client has already been closed.');
}
return stub[methodName].apply(stub, args);
},
(err: Error | null | undefined) => () => {
Expand All @@ -268,9 +271,6 @@ export class WorkflowsClient {
callOptions?: CallOptions,
callback?: APICallback
) => {
if (this._terminated) {
return Promise.reject('The client has already been closed.');
}
return apiCall(argument, callOptions, callback);
};
}
Expand Down
21 changes: 12 additions & 9 deletions synth.metadata
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"updateTime": "2019-12-30T23:10:08.083216Z",
"updateTime": "2020-01-04T00:54:57.530503Z",
"sources": [
{
"git": {
"name": "googleapis-private",
"remote": "https://github.com/googleapis/googleapis-private.git",
"sha": "06c5c6e9caf01113977cf4105cb1b6844771f8f9",
"internalRef": "286483368"
"sha": "c7bc200d62915541e1fd3c3ff6345f92269a3251",
"internalRef": "288042994"
}
},
{
Expand Down Expand Up @@ -95,9 +95,6 @@
{
"path": "protos/google/cloud/workflows/v1alpha1/workflows.proto"
},
{
"path": "system-test/.eslintrc.yml"
},
{
"path": "system-test/install.ts"
},
Expand Down Expand Up @@ -209,9 +206,6 @@
{
"path": ".kokoro/release/docs.sh"
},
{
"path": "__pycache__/synth.cpython-37.pyc"
},
{
"path": ".github/PULL_REQUEST_TEMPLATE.md"
},
Expand Down Expand Up @@ -575,6 +569,9 @@
{
"path": "node_modules/google-gax/node_modules/@grpc/grpc-js/package.json"
},
{
"path": "node_modules/google-gax/node_modules/@grpc/grpc-js/node_modules/semver/package.json"
},
{
"path": "node_modules/google-gax/node_modules/lru-cache/package.json"
},
Expand Down Expand Up @@ -3461,6 +3458,12 @@
{
"path": "node_modules/typescript/package.json"
},
{
"path": "node_modules/@types/fs-extra/package.json"
},
{
"path": "node_modules/@types/fs-extra/node_modules/@types/node/package.json"
},
{
"path": "node_modules/@types/mocha/package.json"
},
Expand Down
3 changes: 3 additions & 0 deletions synth.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
for version in versions:
library = gapic.typescript_library(
'workflows',
generator_args={
'package-name': '@google-cloud/workflows'
},
version=version,
private=True)

Expand Down
4 changes: 0 additions & 4 deletions system-test/.eslintrc.yml

This file was deleted.

2 changes: 1 addition & 1 deletion system-test/fixtures/sample/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@


/* eslint-disable node/no-missing-require, no-unused-vars */
const workflows = require('workflows');
const workflows = require('@google-cloud/workflows');

function main() {
const workflowsClient = new workflows.WorkflowsClient();
Expand Down
2 changes: 1 addition & 1 deletion system-test/fixtures/sample/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {WorkflowsClient} from 'workflows';
import {WorkflowsClient} from '@google-cloud/workflows';

function main() {
const workflowsClient = new WorkflowsClient();
Expand Down
1 change: 1 addition & 0 deletions system-test/install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import {packNTest} from 'pack-n-play';
import {readFileSync} from 'fs';
import {describe, it} from 'mocha';

describe('typescript consumer tests', () => {
it('should have correct type signature for typescript users', async function() {
Expand Down
1 change: 1 addition & 0 deletions test/gapic-workflows-v1alpha1.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import * as protosTypes from '../protos/protos';
import * as assert from 'assert';
import {describe, it} from 'mocha';
const workflowsModule = require('../src');

const FAKE_STATUS_CODE = 1;
Expand Down