Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64bit fields no longer support None values in v1.19.6 #271

Closed
larkee opened this issue Oct 26, 2021 · 1 comment · Fixed by #272
Closed

64bit fields no longer support None values in v1.19.6 #271

larkee opened this issue Oct 26, 2021 · 1 comment · Fixed by #272
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@larkee
Copy link

larkee commented Oct 26, 2021

The Cloud Spanner emulator tests began failing yesterday with the following error:

tests/system/test_session_api.py:2150: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
google/cloud/spanner_v1/database.py:1127: in generate_query_batches
    partitions = self._get_snapshot().partition_query(
google/cloud/spanner_v1/snapshot.py:525: in partition_query
    partition_options = PartitionOptions(
.nox/system-3-8/lib/python3.8/site-packages/proto/message.py:516: in __init__
    pb_value = marshal.to_proto(pb_type, value)
.nox/system-3-8/lib/python3.8/site-packages/proto/marshal/marshal.py:211: in to_proto
    pb_value = rule.to_proto(value)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <proto.marshal.rules.stringy_numbers.Int64Rule object at 0x7fd4dcc59940>
value = None

    def to_proto(self, value):
>       return self._python_type(value)
E       TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

.nox/system-3-8/lib/python3.8/site-packages/proto/marshal/rules/stringy_numbers.py:34: TypeError

I have confirmed that this isn't an issue when using v1.19.5.

@larkee larkee added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 26, 2021
@tseaver
Copy link
Contributor

tseaver commented Oct 27, 2021

Regression introduced in #267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants