Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto JSON cannonical encoding is not supported for special types #333

Closed
vam-google opened this issue Aug 2, 2022 · 0 comments · Fixed by #334
Closed

Proto JSON cannonical encoding is not supported for special types #333

vam-google opened this issue Aug 2, 2022 · 0 comments · Fixed by #334
Assignees
@vam-google
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@vam-google
Copy link
Contributor

With an exception of int64<->string encoding (implemented in #267) the rest of special types JSON Mapping are not supported. Most commonly failing types are Timestamp, FieldMask and Duration

This is crucial to support rest transport in Python.
@vam-google vam-google added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 2, 2022
@vam-google vam-google self-assigned this Aug 2, 2022
vam-google added a commit to vam-google/proto-plus-python that referenced this issue Aug 4, 2022
@vam-google
fix: Fix Timestamp, Duration and FieldMask marshaling in REST transport
ad6bbdd 
This fixes googleapis#333
@vam-google vam-google mentioned this issue Aug 4, 2022
Merged
vam-google added a commit that referenced this issue Aug 5, 2022
@vam-google
fix: Fix Timestamp, Duration and FieldMask marshaling in REST transpo…
a2e7300 
…rt (#334)

* fix: Fix Timestamp, Duration and FieldMask marshaling in REST transport

This fixes #333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vam-google vam-google

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix Timestamp, Duration and FieldMask marshaling in REST transport vam-google/proto-plus-python
1 participant
@vam-google