Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utcnow is deprecated in python3.12 #540

Closed
kasium opened this issue Oct 20, 2023 · 0 comments · Fixed by #552 or #555
Closed

utcnow is deprecated in python3.12 #540

kasium opened this issue Oct 20, 2023 · 0 comments · Fixed by #552 or #555
Assignees
@ohmayr
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@kasium
Copy link

kasium commented Oct 20, 2023

Environment details

  • OS type and version: Linux
  • Python version: 3.12.0
  • pip version: 23.2.1
  • google-api-core version: 2.10.2

Issue

The following code uses utcnow which is deprecated in python 3.12

python-api-core/google/api_core/datetime_helpers.py

Lines 43 to 46 in 405272c

def utcnow():
"""A :meth:`datetime.datetime.utcnow()` alias to allow mocking in tests."""
return datetime.datetime.utcnow()

@MarkDaoust MarkDaoust mentioned this issue Oct 20, 2023
Closed
@vchudnov-g vchudnov-g added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Nov 6, 2023
DouglasBlackwood added a commit to DouglasBlackwood/python-api-core that referenced this issue Nov 9, 2023
@DouglasBlackwood
refactor: replace deprecated datetime.datetime.utcnow()
15b044a 
Fixes googleapis#540
@DouglasBlackwood DouglasBlackwood mentioned this issue Nov 9, 2023
Merged
parthea added a commit that referenced this issue Nov 17, 2023
@DouglasBlackwood @parthea
fix: replace deprecated datetime.datetime.utcnow() (#552)
448923a 
Fixes #540

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@release-please release-please bot mentioned this issue Nov 17, 2023
Merged
@parthea parthea mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ohmayr ohmayr

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
3 participants
@vchudnov-g @kasium @ohmayr