Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated datetime.datetime.utcnow() #552

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

DouglasBlackwood
Copy link
Contributor

@DouglasBlackwood DouglasBlackwood commented Nov 9, 2023

datetime.datetime.utcnow() is deprecated in Python 3.12.

Fixes #540

@DouglasBlackwood DouglasBlackwood requested review from a team as code owners November 9, 2023 22:06
Copy link

google-cla bot commented Nov 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 9, 2023
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. Waiting for presubmits before formally approving.

@DouglasBlackwood
Copy link
Contributor Author

This looks fine. Waiting for presubmits before formally approving.

I'm sorry, I'm not familiar with this repository yet. What are presubmits? Do I have to do something?

@parthea parthea changed the title refactor: replace deprecated datetime.datetime.utcnow() fix: replace deprecated datetime.datetime.utcnow() Nov 17, 2023
@parthea parthea merged commit 448923a into googleapis:main Nov 17, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

utcnow is deprecated in python3.12
3 participants