Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1): resolve issue handling protobuf responses in rest streaming #609

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: resolve issue handling protobuf responses in rest streaming (#604)

  • fix: resolve issue handling protobuf responses in rest streaming

  • raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

  • remove response_type from pytest.mark.parametrize

  • 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

  • add test for ValueError in response_iterator._grab()

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: resolve issue handling protobuf responses in rest streaming

* raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

* remove response_type from pytest.mark.parametrize

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add test for ValueError in response_iterator._grab()

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested review from a team as code owners February 13, 2024 17:03
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 13, 2024
@parthea parthea changed the title fix: resolve issue handling protobuf responses in rest streaming (#604) * fix: resolve issue handling protobuf responses in rest streaming * raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message * remove response_type from pytest.mark.parametrize * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add test for ValueError in response_iterator._grab() --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> fix: resolve issue handling protobuf responses in rest streaming Feb 13, 2024
@parthea parthea changed the title fix: resolve issue handling protobuf responses in rest streaming fix(v1): resolve issue handling protobuf responses in rest streaming Feb 13, 2024
@parthea parthea merged commit d386d2e into v1 Feb 13, 2024
21 checks passed
@parthea parthea deleted the cherry-pick-c8ba66-v1 branch February 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants