Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v1): resolve issue handling protobuf responses in rest streaming #608

Closed
wants to merge 5 commits into from

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Feb 13, 2024

The changes in this PR were created using git cherry-pick bcebc92eca69dae81c5e546d526c92b164a6b3b4

These commits were also added to resolve issues with presubmits:

8fb3819
deae4a0
b4cab0d
ba6e647


  • fix: resolve issue handling protobuf responses in rest streaming

  • raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

  • remove response_type from pytest.mark.parametrize

  • 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

  • add test for ValueError in response_iterator._grab()

* fix: resolve issue handling protobuf responses in rest streaming

* raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

* remove response_type from pytest.mark.parametrize

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add test for ValueError in response_iterator._grab()

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@parthea parthea requested review from a team as code owners February 13, 2024 16:46
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 13, 2024
@parthea
Copy link
Collaborator Author

parthea commented Feb 13, 2024

Prefer #609 and #610

@parthea parthea closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant