Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dependencies): increase protobuf version #49

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fix(dependencies): increase protobuf version #49

merged 1 commit into from
Jun 16, 2020

Conversation

busunkim96
Copy link
Contributor

Increase protobuf version to 3.12.0 for _internal_create_key.

See protocolbuffers/protobuf@b99994d for the commit where this was added.

Fixes #48 🦕

@busunkim96
fix(dependencies): increase protobuf version
9e15e36 
Increase protobuf version to 3.12.0 for `_internal_create_key`. Closes #48
@busunkim96 busunkim96 requested review from crwilcox and plamut June 15, 2020 16:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2020
plamut
plamut approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

With protobuf==3.12.0, the following import does not result in an error anymore, unlike in some older protobuf versions:

from google.cloud.pubsub_v1.types import PushConfig

@busunkim96 busunkim96 merged commit 1ba6095 into master Jun 16, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 16, 2020
@release-please
chore: release 1.20.1 (#51)
7531a5e 
🤖 I have created a release \*beep\* \*boop\* 
---
### [1.20.1](https://www.github.com/googleapis/python-api-core/compare/v1.20.0...v1.20.1) (2020-06-16)


### Bug Fixes

* **dependencies:** increase protobuf version ([#49](https://www.github.com/googleapis/python-api-core/issues/49)) ([1ba6095](https://www.github.com/googleapis/python-api-core/commit/1ba609592968c9d828449b89a3ade3bcaf5edd7f)), closes [#48](https://www.github.com/googleapis/python-api-core/issues/48)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@tseaver tseaver deleted the busunkim96-patch-1 branch December 8, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating the pubsub client breaks because it needs a newer version of protobuf
3 participants
@busunkim96 @plamut @googlebot