fix: fix regression in bidi causing Thread-ConsumeBidirectionalStream caught unexpected exception and will exit
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e120a0c.
ohmayr
approved these changes
Dec 1, 2023
vchudnov-g
reviewed
Dec 1, 2023
| return self.call is not None and self.call.is_active() | ||
| # seeing if it's active. We need to return True if self.call is None. | ||
| # See https://github.com/googleapis/python-api-core/issues/560. | ||
| if self.call is not None and not self.call.is_active(): |
There was a problem hiding this comment.
It would be simpler and much clearer to have return self.call is None or self.call.is_active(). This is equivalent to what you have, by DeMorgan's theorem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e120a0c
Fixes #560