Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for asynchronous rest streaming #686
feat: add support for asynchronous rest streaming #686
Changes from 17 commits
4df2120
26f52a5
204920a
2014ef6
fdeb437
8014f47
e84f03a
91f5c13
0c2ee5c
75ae7d7
db7cfb3
9da0113
87eeca3
d6abddd
a6a648d
8d30b2d
0b51b09
7d8f1e1
d793069
5f48f72
70d1cdb
ee3a5ac
5a6e488
f2180da
bc811e5
fc74ae0
1603818
cee06ab
380dedf
750d4cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this exception raised? Line 46 will succeed with a matching method of any class, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's reasonable to not raise an error for this. We've added the relevant type hints. Cleaned up the docstring.