-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add automatic logging config to support debug logging #754
Conversation
f8cb7fc
to
ff594d3
Compare
ff594d3
to
7b1605c
Compare
# Fields to be included in the StructuredLogFormatter. | ||
# | ||
# TODO(https://github.com/googleapis/python-api-core/issues/761): Update this list to support additional logging fields. | ||
_recognized_logging_fields = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to note is that users will need to update google-api-core
to get any additional logging fields in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true. Any fields that we add in the future will require users to update google-api-core
.
Implement automatic logging config to allow users to enable debug logging via an environment variable.
Fixes b/381099872