Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ashleyxuu committed Apr 12, 2024
1 parent f2e4f34 commit 4d12f97
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions bigquery_magics/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,8 @@
from google.api_core import client_info
from google.api_core.exceptions import NotFound
from google.cloud import bigquery
from google.cloud.bigquery import _versions_helpers, exceptions
from google.cloud.bigquery import _versions_helpers, exceptions
from google.cloud.bigquery import exceptions
from google.cloud.bigquery.dbapi import _helpers
from google.cloud.bigquery import _versions_helpers

from bigquery_magics import line_arg_parser as lap
import bigquery_magics.config
Expand Down Expand Up @@ -612,7 +610,9 @@ def _make_bqstorage_client(client, use_bqstorage_api, client_options):
return None

try:
_versions_helpers.BQ_STORAGE_VERSIONS.try_import(raise_if_error=True)
bigquery_magics._versions_helpers.BQ_STORAGE_VERSIONS.try_import(
raise_if_error=True
)
except exceptions.BigQueryStorageNotFoundError as err:
customized_error = ImportError(
"The default BigQuery Storage API client cannot be used, install "
Expand Down
2 changes: 1 addition & 1 deletion samples/snippets/query_params_scalars.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

def query_with_parameters() -> "pandas.DataFrame":
ip = IPython.get_ipython()
ip.extension_manager.load_extension("google.cloud.bigquery")
ip.extension_manager.load_extension("bigquery_magics")

sample = """
# [START bigquery_jupyter_query_params_scalars]
Expand Down
4 changes: 2 additions & 2 deletions samples/snippets/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ google-cloud-bigquery-storage==2.24.0
ipython===7.31.1; python_version == '3.7'
ipython===8.0.1; python_version == '3.8'
ipython===8.18.1; python_version >= '3.9'
pandas==1.3.5; python_version == '3.7'
pandas==2.0.0; python_version == '3.8'
pandas===1.3.5; python_version == '3.7'
pandas===2.0.3; python_version == '3.8'
pandas==2.2.1; python_version >= '3.9'

0 comments on commit 4d12f97

Please sign in to comment.