Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update required checks #12

Closed
tswast opened this issue Apr 11, 2024 · 2 comments · Fixed by #19 or #25
Closed

chore: update required checks #12

tswast opened this issue Apr 11, 2024 · 2 comments · Fixed by #19 or #25
Assignees
@chelsea-lin
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Apr 11, 2024

In #7, I commented out several required checks. We should add these back in https://github.com/googleapis/python-bigquery-magics/blob/main/.github/sync-repo-settings.yaml

Some notes:

  • Samples: blocked by chore: add bigquery-magics samples #9
  • "Kokoro": maybe redundant with system tests and/or unit tests and linting. We may want to drop that in favor of the smaller test jobs.
@tswast tswast added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 11, 2024
@tswast tswast assigned tswast and unassigned tswast Apr 11, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-magics API. label Apr 11, 2024
@chelsea-lin chelsea-lin mentioned this issue Apr 11, 2024
Merged
4 tasks
@tswast tswast reopened this Apr 12, 2024
@tswast
Copy link
Collaborator Author

tswast commented Apr 12, 2024 •
edited
Loading

Re-opening so that we require:

  • Kokoro system-3.12
  • samples once we have those

@tswast
Copy link
Collaborator Author

tswast commented Apr 15, 2024 •
edited
Loading

Samples have been merged in #9

We can add at least one samples tests to the required checks.

@chelsea-lin chelsea-lin mentioned this issue Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@tswast @chelsea-lin