Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add bigquery-magics samples #9

Merged
merged 20 commits into from
Apr 15, 2024
Merged

chore: add bigquery-magics samples #9

merged 20 commits into from
Apr 15, 2024

Conversation

ashleyxuu
Copy link
Contributor

No description provided.

@ashleyxuu ashleyxuu requested a review from tswast April 11, 2024 18:53
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-magics API. samples Issues that are directly related to samples. labels Apr 11, 2024
tswast
tswast requested changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The samples need to be one directory deeper. Could you please make a samples/bigquery folder for the %%bigquery code samples?

@tswast
Copy link
Collaborator

tswast commented Apr 11, 2024

Looking at #6, the recommended folder name is samples/snippets so we can use that.

tswast
tswast reviewed Apr 11, 2024
View reviewed changes
samples/query.py Outdated Show resolved Hide resolved
@tswast tswast mentioned this pull request Apr 11, 2024
Closed
@product-auto-label product-auto-label bot added size: l Pull request size is large. size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Apr 12, 2024
@ashleyxuu ashleyxuu marked this pull request as ready for review April 12, 2024 03:41
@ashleyxuu ashleyxuu requested review from a team as code owners April 12, 2024 03:41
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 12, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 12, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Apr 12, 2024
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-samples branch from 9db0a67 to f2e4f34 Compare April 12, 2024 20:50
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Apr 12, 2024
tswast
tswast reviewed Apr 12, 2024
View reviewed changes
bigquery_magics/bigquery.py Outdated
@@ -97,7 +97,7 @@
from google.api_core import client_info
from google.api_core.exceptions import NotFound
from google.cloud import bigquery
from google.cloud.bigquery import exceptions
from google.cloud.bigquery import _versions_helpers, exceptions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't.

That's a private module. Let's use the one we copied to this repo, instead.

tswast
tswast reviewed Apr 12, 2024
View reviewed changes
samples/snippets/requirements.txt Outdated
Comment on lines 1 to 9
db-dtypes==1.2.0
google.cloud.bigquery==3.19.0
google-cloud-bigquery-storage==2.24.0
ipython===7.31.1; python_version == '3.7'
ipython===8.0.1; python_version == '3.8'
ipython===8.18.1; python_version >= '3.9'
pandas==1.3.5; python_version == '3.7'
pandas==2.0.0; python_version == '3.8'
pandas==2.2.1; python_version >= '3.9'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this will just be bigquery_magics with no extra dependencies. See this comment: https://github.com/googleapis/python-bigquery/blob/bf8861c3473a1af978db7a06463ddc0bad86f326/samples/snippets/requirements.txt#L1

@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-samples branch from d3a899e to 4d12f97 Compare April 12, 2024 21:48
ashleyxuu and others added 16 commits April 12, 2024 22:09
@ashleyxuu
chore: add the sample test for magics
fb9fea4
@ashleyxuu
re-arrange directory and make nox -s pass
150324b
@ashleyxuu
chore: add the sample test for magics
7ddb606
@tswast @ashleyxuu
chore: copy %%bigquery magics tests from google-cloud-bigquery (#8)
48c5fda 
* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage
@ashleyxuu
re-arrange directory and make nox -s pass
9a743ec
@ashleyxuu
delete files
4a3c4d1
@ashleyxuu
test the version
b1dcde6
@ashleyxuu
chore: add the sample test for magics
5d5a621
@ashleyxuu
re-arrange directory and make nox -s pass
767acf7
@ashleyxuu
chore: add the sample test for magics
e555729
@tswast @ashleyxuu
chore: copy %%bigquery magics tests from google-cloud-bigquery (#8)
111a92f 
* chore: copy magics unit tests from google-cloud-bigquery

* update tests to use bigquery_magics module

* remove auth from unit tests

* fix coverage
@ashleyxuu
re-arrange directory and make nox -s pass
589e0bc
@ashleyxuu
delete files
f7b11e8
@gcf-owl-bot @ashleyxuu
🦉 Updates from OwlBot post-processor
dd6d3ec 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@ashleyxuu
delete files
7836f4a
@ashleyxuu
address comments
d4fd1ae
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-samples branch from d012645 to d4fd1ae Compare April 12, 2024 23:06
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-samples branch from c6aca5f to 1105998 Compare April 14, 2024 19:05
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-samples branch from 0ae053e to 1d21466 Compare April 15, 2024 16:16
@ashleyxuu ashleyxuu force-pushed the ashleyxu-add-samples branch from 87ab992 to 2be7369 Compare April 15, 2024 16:19
tswast
tswast approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit dfc64b8 into main Apr 15, 2024
23 of 25 checks passed
@tswast tswast deleted the ashleyxu-add-samples branch April 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@rsamborski rsamborski Awaiting requested review from rsamborski rsamborski is a code owner automatically assigned from googleapis/python-samples-reviewers

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx alvarowolfx is a code owner automatically assigned from googleapis/api-bigquery

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-magics API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleyxuu @tswast