Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: make use_bqstorage_api True by default #293

Open
3 tasks
tswast opened this issue Oct 27, 2019 · 5 comments
Open
3 tasks

ENH: make use_bqstorage_api True by default #293

tswast opened this issue Oct 27, 2019 · 5 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Oct 27, 2019

It’ll give people the best experience if the fast method is also the default method. Since this requires an additional API to be enabled, it’s technically a breaking change. Similar to how we handled the switch to standard SQL in #195, I propose we complete this work in two phases:

  • Add use_bqstorage_api to the global context object with a value of False. It is overridable by setting pandas_gbq.context.use_bqstorage_api = True. If the default value of use_bqstorage_api=None is passed into read_gbq, it uses the default value from the global context.
  • Make a release with this new context value. (Make sure pandas.read_gbq also sends down None for use_bqstorage_api if not supplied.)
  • Update default value in the global context to True. (Possibly after the BigQuery Storage API goes GA, though maybe sooner.)
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 27, 2019
@ketozhang
Copy link

Any news on when this will be implemented?

@tswast
Copy link
Collaborator Author

tswast commented Mar 15, 2021

Nothing blocking it, now that the API is GA. We probably want to use the create_bqstorage_client parameter in the to_dataframe method for future compatibility.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jul 17, 2021
@tswast
Copy link
Collaborator Author

tswast commented Dec 6, 2021

This is long overdue. Bumping the priority on this.

@tswast tswast self-assigned this Dec 6, 2021
@tswast tswast removed their assignment May 9, 2022
@Et9797
Copy link

Et9797 commented May 15, 2024

Doesn't use_bqstorage_api=True incur more cost? Or is kind of neglible when you're talking roughly 1-10GBs of data?

@tswast
Copy link
Collaborator Author

tswast commented May 15, 2024

It's free to read from anonymous tables created by a query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants