-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Standard SQL Default #195
Comments
It is a breaking change so we’ll want to communicate it widely, but I’m supportive of this proposal. |
Shall we:
@RafaelAMello if you agree, would you be interested in creating a PR? |
Yup happy to do it, When do you think it's best then change the default parameter to Thanks! |
Great, something like If @tswast agrees, I think we change the default in 0.6, assuming that's a few months away? If someone upgrades past the warning, their code will obviously break rather than return an incorrect result (although won't be clear why it broke) so it's bad but not disastrous. |
Sounds like a good plan to me. |
* CLN: Warn that default dialect is changing to "standard" Towards issue #195 * Increment stacklevel so line where read_gbq is called is highlighted. * Update pyenv * Try Python 2.7.15 via Travis build instead of pyenv * Add to changelog * Remove unused TRAVIS_PYTHON_VERSION env var.
Let's leave this open to track changing the default; the warning is merged, courtesy of @tswast (should we do a release with this?) |
I actually made a release last week. https://pypi.org/project/pandas-gbq/0.6.0/ I forgot to add the release info to GitHub, though. I'll do that now. |
Great, thanks! |
We need to update the samples at https://pandas-gbq.readthedocs.io/en/latest/reading.html to show an explicit dialect. |
Good point @tswast We could also change the default now? |
Now that #235 is in and released as part of 0.8 it is possible for people to change the default dialect back to legacy if they really need to. We can now change the default to standard SQL. |
Heya!
In the new BigQuery UI Google is rolling out standard SQL as the default for queries, I am wondering if we can do the same with operations using this package?
This is a small connivance but it gets me every time.
Thanks!
The text was updated successfully, but these errors were encountered: