Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Standard SQL Default #195

Closed
RafaelAMello opened this issue Aug 3, 2018 · 12 comments
Closed

Make Standard SQL Default #195

RafaelAMello opened this issue Aug 3, 2018 · 12 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@RafaelAMello
Copy link

RafaelAMello commented Aug 3, 2018

Heya!

In the new BigQuery UI Google is rolling out standard SQL as the default for queries, I am wondering if we can do the same with operations using this package?

This is a small connivance but it gets me every time.

Thanks!

@tswast
Copy link
Collaborator

tswast commented Aug 3, 2018

It is a breaking change so we’ll want to communicate it widely, but I’m supportive of this proposal.

@max-sixty
Copy link
Contributor

Shall we:

  1. Change default to None and warn on None that future versions will have Standard SQL default
  2. In a later version change the default to Standard

@RafaelAMello if you agree, would you be interested in creating a PR?

@RafaelAMello
Copy link
Author

Yup happy to do it,
Should I implement something like the verbose warning depreciation?

When do you think it's best then change the default parameter to standard?

Thanks!

@max-sixty
Copy link
Contributor

Great, something like warnings.warn(msg, FutureWarning) would work.

If @tswast agrees, I think we change the default in 0.6, assuming that's a few months away?

If someone upgrades past the warning, their code will obviously break rather than return an incorrect result (although won't be clear why it broke) so it's bad but not disastrous.

@tswast
Copy link
Collaborator

tswast commented Aug 3, 2018

Change default to None and warn on None that future versions will have Standard SQL default
In a later version change the default to Standard

Sounds like a good plan to me.

tswast added a commit to tswast/python-bigquery-pandas that referenced this issue Aug 15, 2018
tswast added a commit that referenced this issue Aug 15, 2018
* CLN: Warn that default dialect is changing to "standard"

Towards issue #195

* Increment stacklevel so line where read_gbq is called is highlighted.

* Update pyenv

* Try Python 2.7.15 via Travis build instead of pyenv

* Add to changelog

* Remove unused TRAVIS_PYTHON_VERSION env var.
@max-sixty
Copy link
Contributor

Let's leave this open to track changing the default; the warning is merged, courtesy of @tswast

(should we do a release with this?)

@tswast
Copy link
Collaborator

tswast commented Aug 21, 2018

I actually made a release last week. https://pypi.org/project/pandas-gbq/0.6.0/ I forgot to add the release info to GitHub, though. I'll do that now.

@max-sixty
Copy link
Contributor

Great, thanks!

@tswast
Copy link
Collaborator

tswast commented Sep 5, 2018

Now that we have the pandas_gbq.context object (#208), we could add a dialect property to the context object to allow people to pick their own defaults, as suggested in #103.

To start out, we could populate the default with 'legacy' and switch to 'standard' in a few months.

@tswast
Copy link
Collaborator

tswast commented Oct 29, 2018

We need to update the samples at https://pandas-gbq.readthedocs.io/en/latest/reading.html to show an explicit dialect.

@tswast tswast self-assigned this Oct 29, 2018
@max-sixty
Copy link
Contributor

Good point @tswast

We could also change the default now?

@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 9, 2018
@tswast
Copy link
Collaborator

tswast commented Dec 20, 2018

Now that #235 is in and released as part of 0.8 it is possible for people to change the default dialect back to legacy if they really need to. We can now change the default to standard SQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants