-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add prerelease session to test with latest dependencies, separate compliance tests #401
Conversation
Prerelease tests pass locally:
Even though we use the latest SQLAlchemy, it is passing since we aren't running against the compliance test suite (yet?). |
This reverts commit 01aca60.
@@ -183,6 +183,75 @@ def system(session): | |||
) | |||
|
|||
|
|||
@nox.session(python=DEFAULT_PYTHON_VERSION) | |||
def prerelease(session): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Mostly taken straight from https://github.com/googleapis/python-bigquery-pandas/blob/d4539747848156446d8a3ccdb49661e72ae03109/noxfile.py#L176
googleapis/synthtool#1290 is open to add this to the templates, though it would need to be slightly templated to allow for customized prerelease dependencies.
This comment has been minimized.
This comment has been minimized.
FYI: a pytest release in the past month broke the compliance test suite: #413 Edit: Fixed by capping pytest version to less than 7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Added 1 observation
noxfile.py
Outdated
"google-cloud-bigquery-storage", | ||
"google-cloud-core", | ||
"google-resumable-media", | ||
"grpcio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 4 don't appear in setup.py
. Please could you add a comment to clarify the reason that they're included here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. Possibly we should add google-cloud-bigquery-storage
to setup.py
in a separate PR. It's an "extra" but one that'll raise a warning if not present. The others we get via transitive dependencies. I'll comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mailed #414 which updates some of the dependencies in setup.py
to better reflect reality.
Also, remove google-resumable-media from prerelease tests, as this package does not use load jobs.
…ing (#414) The wrapped DB-API uses google-cloud-bigquery-storage to download query results by default. It raises a warning and falls back to the REST API if google-cloud-bigquery-storage is not installed. The google-cloud-bigquery version 3.x library is tested in #401 and it does not include any breaking changes that should affect the SQLAlchemy connector. deps: allow google-cloud-bigquery version 3.x Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards googleapis/python-bigquery#1021 "Test connectors, such as pandas-gbq and sqlalchemy-bigquery with pre-release, make updates if needed."
Towards #413
Internal CL 422873148 to enable these test sessions in Kokoro.