Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: add retry for query results iteration #24

Closed
tseaver opened this issue Oct 11, 2018 · 1 comment · Fixed by #41
Closed

BigQuery: add retry for query results iteration #24

tseaver opened this issue Oct 11, 2018 · 1 comment · Fixed by #41
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Oct 11, 2018

See: googleapis/google-cloud-python#6136, and the TODO left in the code by @jba:

    def result(self, timeout=None):
        ...
        if self.state is None:
            self._begin()
        # TODO: modify PollingFuture so it can pass a retry argument to done().
        return super(_AsyncJob, self).result(timeout=timeout)
@tseaver
Copy link
Contributor Author

tseaver commented Nov 7, 2018

Progress to date:

@IlyaFaer IlyaFaer self-assigned this Dec 2, 2019
IlyaFaer referenced this issue in MaxxleLLC/google-cloud-python Dec 3, 2019
busunkim96 referenced this issue in googleapis/google-cloud-python Jan 24, 2020
…ors (#9923)

* feat(api_core): add retry param into PollingFuture() and it's inheritors

Towards #6197
@plamut plamut transferred this issue from googleapis/google-cloud-python Feb 4, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 4, 2020
@plamut plamut added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 4, 2020
gcf-merge-on-green bot pushed a commit to googleapis/python-api-core that referenced this issue Oct 16, 2020
@tswast tswast closed this as completed in #41 Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants