-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a static copy of legacy proto-based types #1000
Conversation
"use types defined in google.cloud.bigquery instead." | ||
) | ||
|
||
warnings.warn(_LEGACY_MSG, category=DeprecationWarning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice -- I had been thinking to add a request for import-time warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Oh, wait... didn't we say we want to add back the proto* dependencies, so that those imports will not result in an error? Maybe as a "legacy_types" extra? And what about the intersphinx links? Should we perhaps expose these models in the docs with a big fat "OBSOLETE!" warning at the top? |
Yes, please. I think we've added the BQ Storage API as a required dependency now, right? That should mean we pull those in transitively anyway, but it wouldn't hurt to be explicit.
Yeah, let's make sure we generate docs for it, but with a warning & link to our migration guide. |
Closes #999.
Adding unmaintained legacy types definitions.