Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync v3 with main branch #1088

Merged
merged 15 commits into from
Dec 16, 2021
Merged

chore: sync v3 with main branch #1088

merged 15 commits into from
Dec 16, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 15, 2021 •
edited
Loading

"do not merge" label is just a reminder to use a merge commit

plamut and others added 11 commits November 16, 2021 22:57
@plamut
feat: allow cell magic body to be a $variable (#1053)
3a681e0 
* feat: allow cell magic body to be a $variable

* Fix missing indefinitive article in error msg

* Adjust test assertion to error message change

* Refactor logic for extracting query variable

* Explicitly warn about missing query variable name

* Thest the query "variable" is not identifier case
@plamut
cleanup: silence non-relevant system test warnings (#1068)
1b5dc5c
@judahrand @tswast
feat: promote RowIterator.to_arrow_iterable to public method (#1073)
21cd710 
* feat: promote `to_arrow_iterable` to public method

* use correct version number

* Update google/cloud/bigquery/table.py

Co-authored-by: Tim Swast <swast@google.com>
@plamut
fix: apply timeout to all resumable upload requests (#1070)
3314dfb 
* fix: apply timeout to all resumable upload requests

* Fix stub in test case

* Improve timeout type and other type annotations

* Annnotate return type of _do_resumable_upload()
@release-please
chore: release 2.31.0 (#1066)
a135956 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@tswast
test: check extreme DATE/DATETIME values can be loaded from pandas Da…
be6eb34 
…taFrame (#1078)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Towards #1076 🦕
(edit: moved to googleapis/python-db-dtypes-pandas#45 )
@loferris @gcf-owl-bot
@tswast @plamut @parthea @meredithslota
docs: add sample for revoking dataset access (#778)
effd673 
* revoke dataset access setup

* basic template for sample

* sample + test

* revoke dataset access sample

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

* docs: add sample for revoking dataset access - update year and string formatting

* docs: add sample for revoking dataset access - move to snippets and change parameter pattern for readibility

* moving update_dataset to /snippets and adjusting imports on both revoke_access and update_access

* Update samples/snippets/revoke_dataset_access.py

removed nested START/END tags

Co-authored-by: Tim Swast <swast@google.com>

* Update samples/snippets/revoke_dataset_access.py

update readability in API request

Co-authored-by: Tim Swast <swast@google.com>

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

* updated test

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

* change after running test

* resolving linting failure, rewriting test

* removed relative import errors

* remove relative mport from update_dataset_access

* adding fixture to conftest.py

* updated sample

* updating sample to match new update_access sample

* fixing region tags

* consolidated tests into one file for both methods

* updating test to full_dataset format

* updated revoke sample

* updating test

* refactored sample

* Update samples/snippets/conftest.py

* Update samples/snippets/revoke_dataset_access.py

Co-authored-by: Tim Swast <swast@google.com>

* Update samples/snippets/update_dataset_access.py

Co-authored-by: Tim Swast <swast@google.com>

* Update samples/snippets/revoke_dataset_access.py

Co-authored-by: Tim Swast <swast@google.com>

* Update samples/snippets/revoke_dataset_access.py

Co-authored-by: Tim Swast <swast@google.com>

* refactoring entry

* added comment for entry access

* Update samples/snippets/README.rst

Co-authored-by: Tim Swast <swast@google.com>

* Update samples/snippets/dataset_access_test.py

Co-authored-by: Tim Swast <swast@google.com>

* Update samples/snippets/dataset_access_test.py

Co-authored-by: Tim Swast <swast@google.com>

* added develper TODO in sample

* add comments to samples

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: meredithslota <meredithslota@google.com>
@gcf-owl-bot
chore: update python-docs-samples link to main branch (#1082)
44221f4
@steffnay
feat: support authorized dataset entity (#1075)
c098cd0 
* feat: support authorized dataset entity

* cleanup

* add test and cache the resource from from_api_repr in a _properties value

* lint

* update samples to use enums

* update to_api_repr and add tests

* refactor
@renovate-bot @tswast
chore(deps): update all dependencies (#1005)
4a3ab03 
* chore(deps): update all dependencies

* exclude new geopandas from python 3.6

Co-authored-by: Tim Swast <swast@google.com>
@tswast
Merge remote-tracking branch 'upstream/main' into sync-v3
2b76944
@tswast tswast requested a review from a team December 15, 2021 18:31
@tswast tswast requested review from a team as code owners December 15, 2021 18:31
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 15, 2021
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 15, 2021
@tswast tswast changed the base branch from main to v3 December 15, 2021 18:33
tswast
tswast commented Dec 15, 2021
View reviewed changes
tests/unit/test_table.py Outdated
@@ -2205,6 +2205,25 @@ def test_to_arrow_iterable(self):
[[{"name": "Bepples Phlyntstone", "age": 0}, {"name": "Dino", "age": 4}]],
)

@mock.patch("google.cloud.bigquery.table.pyarrow", new=None)
def test_to_arrow_iterable_error_if_pyarrow_is_none(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I think we can delete this now that pyarrow is a required dependency

@tswast tswast requested a review from plamut December 15, 2021 18:46
@tswast
Copy link
Contributor Author

tswast commented Dec 15, 2021

Note: the diff is a bit smaller than expected because #1081 pulled some changes in from main already

shollyman
shollyman approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that I have no real context on what's in/out of scope for the merge as I've not been following the v3 branch closely.

@plamut
Copy link
Contributor

plamut commented Dec 16, 2021

LGTM, with the caveat that I have no real context on what's in/out of scope for the merge as I've not been following the v3 branch closely.

Everything from the main branch should go into v3, but of course adjusted for the changes in that branch (e.g. some dependencies not optional anymore, better type hints, etc.).

plamut
plamut approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The failures seem transient, a bunch of 500 errors.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 16, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 16, 2021
@plamut
Copy link
Contributor

plamut commented Dec 16, 2021

Hm... the copy table test still consistently fails across all test runs.

@tswast
Copy link
Contributor Author

tswast commented Dec 16, 2021

Hm... the copy table test still consistently fails across all test runs.

Seth filed internal issue 210907595 to get this fixed.

@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 16, 2021
@tswast tswast merged commit 08a9bcc into v3 Dec 16, 2021
@tswast tswast deleted the sync-v3 branch December 16, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@shollyman shollyman shollyman approved these changes

@leahecole leahecole Awaiting requested review from leahecole leahecole was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tswast @plamut @shollyman @yoshi-kokoro @judahrand @loferris @steffnay @renovate-bot