New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor AccessEntry to use _properties pattern #1125

Merged

steffnay merged 51 commits into googleapis:main from steffnay:access-entry-refactor

Apr 8, 2022

+612 −210

Contributor

steffnay commented Jan 31, 2022 •

edited

Loading

Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #1077 🦕

steffnay added 3 commits

January 28, 2022 09:16


          add view, dataset, routine properties

42a4b98


          add properties and unit tests

80c22ec


          lint

2f2a8cd

product-auto-label bot added the api: bigquery label

steffnay added 3 commits

February 5, 2022 12:06


          add properties and tests

a8840ab


          merge

437165f


          remove unused imports

4e37ddf

steffnay marked this pull request as ready for review

February 5, 2022 21:21

steffnay requested a review from a team

February 5, 2022 21:21

steffnay requested a review from a team as a code owner

February 5, 2022 21:21

steffnay requested a review from stephaniewang526

February 5, 2022 21:21


          update test

6e2a7bc

steffnay requested review from tswast and removed request for stephaniewang526

February 5, 2022 21:55

steffnay added 5 commits

February 5, 2022 14:53


          add tests

38b1692


          add tests

4b99d78


          add tests

7eff546


          add more tests

d81076d


          update return type

ee1427b

tswast requested changes

View reviewed changes

Contributor

tswast left a comment

Looking pretty good! I made a few suggestions to use get(...), _get_sub_prop, and _set_sub_prop.

I think we'll need some more unit tests that exercise getting the various properties when they aren't set. Make sure they get None (or whatever the desired default is) instead of raising a KeyError.

google/cloud/bigquery/dataset.py Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

steffnay and others added 7 commits

February 15, 2022 23:16


          Merge branch 'main' of github.com:googleapis/python-bigquery into acc…

9f955c0

…ess-entry-refactor


          Update google/cloud/bigquery/dataset.py

7f68e89

Co-authored-by: Tim Swast <swast@google.com>


          Update google/cloud/bigquery/dataset.py

ec6dc26

Co-authored-by: Tim Swast <swast@google.com>


          Update google/cloud/bigquery/dataset.py

d797026

Co-authored-by: Tim Swast <swast@google.com>


          refactor to use get() and remove self._entity_id

296d764


          add unit tests for property none values

f73411e


          delete unnecessary file

fcd4561

steffnay requested a review from tswast

February 16, 2022 16:35

tswast requested changes

View reviewed changes

Contributor

tswast left a comment

Much better! A few small things

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved


          Update google/cloud/bigquery/dataset.py

b11e914

Co-authored-by: Tim Swast <swast@google.com>

steffnay and others added 3 commits

March 14, 2022 17:04


          Merge branch 'main' into access-entry-refactor

cfc55b8


          Merge branch 'main' into access-entry-refactor

a7600b3


          add table test

steffnay requested a review from tswast

March 18, 2022 20:12


          Merge branch 'main' into access-entry-refactor

0e8c08c

tswast requested changes

View reviewed changes

Contributor

tswast left a comment

Sweet! I think the behavior is right now. Just a nit re: what we're storing in _properties. I'd like us to stay consistent with the other resource classes.

google/cloud/bigquery/dataset.py Outdated

+                  def dataset(self) -> Optional[DatasetReference]:
+                      """API resource representation of a dataset reference."""
+                      return typing.cast(
+                          Optional[DatasetReference],

Contributor

tswast Mar 22, 2022

I'd actually like to see _properties store the REST API version and the property getter call from_api_repr. Same for the other properties.

steffnay and others added 6 commits

March 22, 2022 15:08


          Merge branch 'main' of github.com:googleapis/python-bigquery into acc…

018fa49

…ess-entry-refactor


          Merge branch 'access-entry-refactor' of github.com:steffnay/python-bi…

d85463f

…gquery into access-entry-refactor


          update to use api_repr

01f3734


          Merge branch 'main' into access-entry-refactor

cd36b8c


          Merge branch 'main' into access-entry-refactor

9912f79


          lint

9c367c9

steffnay requested a review from tswast

March 29, 2022 17:52

tswast reviewed

View reviewed changes

google/cloud/bigquery/dataset.py Show resolved Hide resolved

tswast approved these changes

View reviewed changes

Contributor

tswast left a comment

Looking really good! I'll approve, but there are a few edge cases you'll want to handle before merging.

google/cloud/bigquery/dataset.py Outdated Show resolved Hide resolved

google/cloud/bigquery/dataset.py Show resolved Hide resolved

google/cloud/bigquery/dataset.py Show resolved Hide resolved


          Merge branch 'main' into access-entry-refactor

a10b98f

product-auto-label bot added the size: l label

steffnay and others added 8 commits

April 6, 2022 21:52


          Update google/cloud/bigquery/dataset.py

d9b5203

Co-authored-by: Tim Swast <swast@google.com>


          Update google/cloud/bigquery/dataset.py

0e3b391

Co-authored-by: Tim Swast <swast@google.com>


          Update google/cloud/bigquery/dataset.py

2fa34ae

Co-authored-by: Tim Swast <swast@google.com>


          Merge branch 'main' into access-entry-refactor

87645db


          merge

32aaf4b


          Merge branch 'access-entry-refactor' of github.com:steffnay/python-bi…

fd36be1

…gquery into access-entry-refactor


          update tests

84a4f79


          remove repeat type import

steffnay merged commit acd5612 into googleapis:main

release-please bot mentioned this pull request

chore(main): release 3.1.0 #1207

Merged

steffnay deleted the access-entry-refactor branch

April 8, 2022 19:52

waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request


          feat: refactor AccessEntry to use _properties pattern (googleapis#1125)

1aadeea

* add view, dataset, routine properties

* add properties and unit tests

* lint

* add properties and tests

* remove unused imports

* update test

* add tests

* add tests

* add tests

* add more tests

* update return type

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* refactor to use get() and remove self._entity_id

* delete unnecessary file

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* add types, remove unnecessary checks

* fix types

* types

* add type casting

* refactor AccessEntry repr

* update to return DatasetReference

* update to use RoutineRef and TableRef

* add table test

* update to use api_repr

* lint

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* update tests

* remove repeat type import

Co-authored-by: Tim Swast <swast@google.com>

abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request


          feat: refactor AccessEntry to use _properties pattern (googleapis#1125)

c0b1bb4

* add view, dataset, routine properties

* add properties and unit tests

* lint

* add properties and tests

* remove unused imports

* update test

* add tests

* add tests

* add tests

* add more tests

* update return type

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* refactor to use get() and remove self._entity_id

* delete unnecessary file

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* add types, remove unnecessary checks

* fix types

* types

* add type casting

* refactor AccessEntry repr

* update to return DatasetReference

* update to use RoutineRef and TableRef

* add table test

* update to use api_repr

* lint

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* Update google/cloud/bigquery/dataset.py

Co-authored-by: Tim Swast <swast@google.com>

* update tests

* remove repeat type import

Co-authored-by: Tim Swast <swast@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery size: l