-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup resources at startup #1741
Merged
chalmerlowe
merged 9 commits into
googleapis:main
from
kiraksi:cleanup-resources-at-startup
Jan 17, 2024
Merged
chore: cleanup resources at startup #1741
chalmerlowe
merged 9 commits into
googleapis:main
from
kiraksi:cleanup-resources-at-startup
Jan 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: bigquery
Issues related to the googleapis/python-bigquery API.
labels
Dec 4, 2023
kiraksi
changed the title
Cleanup resources at startup
chore: cleanup resources at startup
Dec 4, 2023
chalmerlowe
reviewed
Dec 8, 2023
kiraksi
requested review from
alvarowolfx,
engelke and
tswast
and removed request for
engelke and
alvarowolfx
December 13, 2023 18:55
@kiraksi Per our discussion:
|
chalmerlowe
reviewed
Dec 20, 2023
chalmerlowe
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 8, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 8, 2024
kiraksi
force-pushed
the
cleanup-resources-at-startup
branch
from
January 10, 2024 18:29
4704e7a
to
1a9dbe6
Compare
chalmerlowe
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery API.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #590 🦕