Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tests to support latest google-cloud-core #276

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 23, 2020

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.

Closes #294

@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2020
@tswast tswast requested a review from a team September 23, 2020 15:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 24, 2020
@tswast tswast mentioned this pull request Oct 5, 2020
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@tswast tswast force-pushed the google-cloud-core-1.4.2rc1 branch from 3f1ebe2 to d5ed504 Compare October 5, 2020 14:05
@tswast tswast requested a review from a team October 5, 2020 18:44
@steffnay steffnay merged commit 9da28e5 into googleapis:master Oct 6, 2020
@tswast tswast deleted the google-cloud-core-1.4.2rc1 branch October 6, 2020 17:57
parthea pushed a commit that referenced this pull request Mar 12, 2022
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
tswast added a commit that referenced this pull request Mar 25, 2022
…1166)

* chore(deps): allow google-api-core v2 on v1 release

* chore: also update cloud-core

* test: update tests to support latest google-cloud-core (#276)

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.

* ci: fix docs build

* chore: update system tests and samples to use and @google.com email address (#942)

* chore: update system tests and samples to use and @google.com email address

* Add group prefix

* fixed access entry some more

Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Jim Fulton <jim@jimfulton.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests failed into the master branch
3 participants