-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Prepare for 2.0 release #278
Conversation
ace6762
to
8795ec8
Compare
74257b1
to
94c50cf
Compare
BQ Storage 2.0.0 released, re-running. |
FWIW, the snippets tests in diff --git samples/snippets/noxfile.py samples/snippets/noxfile.py
index 5660f08..66589f5 100644
--- samples/snippets/noxfile.py
+++ samples/snippets/noxfile.py
@@ -158,14 +158,17 @@ def _session_tests(session, post_install=None):
session.install("-r", "requirements-test.txt")
if INSTALL_LIBRARY_FROM_SOURCE:
- session.install("-e", _get_repo_root())
+ session.install("-e", _get_repo_root() + "[all]")
if post_install:
post_install(session)
diff --git samples/snippets/requirements.txt samples/snippets/requirements.txt
index 7fe8391..4753c47 100644
--- samples/snippets/requirements.txt
+++ samples/snippets/requirements.txt
@@ -1,4 +1,4 @@
-google-cloud-bigquery[pandas,bqstorage,pyarrow]==1.26.1
+# google-cloud-bigquery[pandas,bqstorage,pyarrow]==1.26.1
google-auth-oauthlib==0.4.1
ipython==7.16.1; python_version < '3.7'
ipython==7.17.0; python_version >= '3.7' |
Do we need to add the necessary extras to |
The assertion seems to fail for a banal reason, i.e. an extra newline in the string representation.
Since it looks like python-bigquery/samples/snippets/noxfile.py Line 155 in fbbe0cb
Maybe I missed some logic that filters out |
@tswast Ah, I think that's probably because I temporarily commented out the (and then had to adjust the installation from source line in noxfile to actually get all those extras installed) |
There are currently no public API endpoints for the ModelServiceClient, thus there is no point in generating that code in the first place.
e31d97a
to
7a4084e
Compare
The old pin (1.4.0) does not work, tests detected some problem.
Hammer merging to work around sample tests. |
This PR should serve as a preview of the 2.0 release.
For a start, the BQ Storage
v1beta1
compatibility code is removed, as it will not be needed anymore once BQ Storage v2.0.0 is released.TODO list:
bigquery_v2
changes.bigquery_v2
changes in UPGRADING guide.bigquery_v2
in them, if necessary.