-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken create_job method #300
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f305f04
fix: broken create_job method
HemangChothani f98950a
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani 38ce75e
fix: changes in unit tests
HemangChothani 8a27c7c
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani 14bbe01
fix: fix sourceTable thing
HemangChothani 64549c4
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani f94998f
fix: handle sourceTable passed in job resource
HemangChothani d8b9e77
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani b578c90
fix: resolve conflict and address comments
HemangChothani e130f9a
fix: remove delete destination table from query
HemangChothani 5c7a39b
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani 4223b78
fix: revert destination table for query
HemangChothani 104294a
Merge branch 'master' of https://github.com/googleapis/python-bigquer…
HemangChothani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to guard this check with
isinstance(TableReference, destination)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mock further in test so now it cover
to_api_repr
. I am not sure about the guard to check instance becausejob_config
is dict and as per the example it has values in the string format.