Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update Job classes to use common _properties pattern #323

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 13, 2020

Instead of mixing _properties and plain-old Python objects, always use
_properties as the source of truth.

This has the side-effect of properly reloading the whole job resource.
Previously some properties were not reloaded.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #297 🦕

Instead of mixing _properties and plain-old Python objects, always use
_properties as the source of truth.

This has the side-effect of properly reloading the whole job resource.
Previously some properties were not reloaded.
@tswast tswast requested a review from a team October 13, 2020 18:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020
@steffnay steffnay merged commit d093cd4 into googleapis:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants