fix: do not remove destinationTable from job config (#483)

[dinigo]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #483 🦕

[plamut]

@dinigo Thanks for the PR.

The changes need to be covered with the corresponding test(s), but it's not entirely clear what is the expected behavior here (as discussed on the ticket). Let's wait until that gets clarified.

[tswast]

As discussed in #483 the create_job function was initially added so that customers could retry jobs. Since the destination table isn't writable when it is an anonymous temporary table, we delete this property.

I agree that this was too aggressive, and to be a general create_job function we should only strip destinationTable when the temporary table datasetId begins with _ and the tableId begins with anon.

As @plamut unit tests need to be updated to cover this change in logic.

[tswast]

Now that we're considering a 3.0.0 release, I'd like us to revisit this request.

I believe to implement #539 @jimfulton will be adding a property to XYZJob classes with a copy of the original request that created the job. This could be used instead of trying to add/remove properties from the job resource that we get from the response.

Closing in favor of a future PR, tied to the 3.0.0 release.