-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove default timeout #974
Conversation
Internal folks, see: go/microgenerator-retries "Methods will **not** hedge by default." (emphasis mine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been confirmed internally as the root cause for the issue the user was facing?
The code change itself looks good.
SRE and API core teams recommends not setting default timeout. Client should still be able to set timeouts in the case when an operation needs to finish within a certain time or else fail. |
In the internal go/microgenerator-retries document, default timeouts + retrying on timeout error is defined as a form of hedging, which is not supposed to happen in our clients. |
Thanks for elaborating, let's merge it then. |
Internal folks, see: go/microgenerator-retries > "Methods will **not** hedge by default." (emphasis mine) Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes googleapis#970 🦕
Internal folks, see: go/microgenerator-retries
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #970 🦕