Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove py.typed since package fails mypy check #988

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 27, 2021

@tswast tswast requested a review from a team September 27, 2021 18:39
@tswast tswast requested a review from a team as a code owner September 27, 2021 18:39
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2021
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2021
@tswast
Copy link
Contributor Author

tswast commented Sep 27, 2021

Will check the library with mypy before reverting.

@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2021
@tswast tswast merged commit 39030f2 into main Sep 27, 2021
@tswast tswast deleted the revert-976-py-typed branch September 27, 2021 19:01
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 27, 2021
@plamut
Copy link
Contributor

plamut commented Sep 27, 2021

Do we know what exactly caused that error? Is it an issue with some of our annotations, or does mypy behave differently from pytype?

It would be good to fix this while still retaining py.typed, although removing it as a short term fix to unblock maintainers of other is fine.

abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants