Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add samples from bigtable #38

Merged
merged 185 commits into from
Jun 4, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented May 28, 2020

tswast and others added 30 commits June 9, 2016 14:37
…rm/python-docs-samples#371)

* Add Bigtable hello world sample.
* Update secrets for Bigtable tests.
Also, change the sample to use sequential keys (with a disclaimer) to
match the Java sample. I had forgotten to add a sample usage to get a
specific row, so add that, too.
…table

Add region tags to bigtable/hello sample.
I noticed that the `bigtable/hello` sample was not quitting when I sent
a `Ctrl-C` this should fix that problem.
…table

Close HappyBase connection in bigtable/hello sample.
…table

bigtable: add raw gcloud-python hello sample.
…table

bigtable: add raw gcloud-python hello sample.
Table of Contents generated with:

    doctoc --title '**Table of Contents**' bigtable

Needs to wait for next gcloud-python launch. Tested locally with a
previous version of grpcio.
Table of Contents generated with:

    doctoc --title '**Table of Contents**' bigtable

Needs to wait for next gcloud-python launch. Tested locally with a
previous version of grpcio.
Change-Id: I6bf9a8acb9ba7d067b3095b5857094cbc322ff58
Change-Id: I6bf9a8acb9ba7d067b3095b5857094cbc322ff58
@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 28, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 28, 2020
@busunkim96 busunkim96 changed the title docs: add samples from bigtable/quickstart docs: add samples from bigtable May 28, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 28, 2020
@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 28, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@busunkim96 busunkim96 requested a review from kolea2 May 28, 2020 19:46
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 2, 2020
@busunkim96
Copy link
Contributor Author

@kolea2 Any idea what's up with the system tests? It seems to consistently be the same failure

@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2020
@kolea2 kolea2 merged commit 1121f0d into googleapis:master Jun 4, 2020
@busunkim96 busunkim96 deleted the add-quickstart-samples branch June 4, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.