Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

docs: add instructions to build a location path #70

Conversation

ricardolsmendes
Copy link
Contributor

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass - N/A
  • Code coverage does not decrease (if any source code was changed) - N/A
  • Appropriate docs were updated (if necessary)

Fixes #68 🦕

@ricardolsmendes ricardolsmendes requested a review from a team as a code owner October 17, 2020 15:46
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2020
@tswast
Copy link
Contributor

tswast commented Nov 17, 2020

@ricardolsmendes
Copy link
Contributor Author

Looks like these helpers were added back in https://github.com/googleapis/python-datacatalog/pull/64/files#diff-88240775a7bf30997273f4cd159e38bbff4ef74a98e065ec045706d3acf5f125R287

(To be released in 3.0 #71)

Thanks for letting me know, @tswast!

@ricardolsmendes
Copy link
Contributor Author

ricardolsmendes commented Nov 18, 2020

Hey @tswast, I've tested v3.0.0 and the helper methods are back but with slightly different names, prefixed with common_: common_billing_account_path, common_folder_path, common_location_path, common_organization_path, and common_project_path.

Maybe it's worth keeping this change to the v2.0,0 migration guide and write new instructions to the v3.0.0. WDYT? 🤔

@tswast
Copy link
Contributor

tswast commented Nov 18, 2020

Since 2.0 hasn't been out all that long, maybe we should update the guide to be from 1.0 to 3.0?

@ricardolsmendes
Copy link
Contributor Author

ricardolsmendes commented Nov 18, 2020

Since 2.0 hasn't been out all that long, maybe we should update the guide to be from 1.0 to 3.0?

Makes sense. I can work on this in a couple of days if it works for you.

@ricardolsmendes
Copy link
Contributor Author

Closing this PR because I'm updating the upgrade guide to be from 1.0 to 3.0 in #77...

@ricardolsmendes ricardolsmendes deleted the update-2.0.0-mogration-guide branch November 22, 2020 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

location_path helper method removed in v2.0.0 is not mentioned in the Migration Guide
2 participants