Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto-plus >= 1.25 needed for python 3.13 #571

Open
parthea opened this issue Oct 25, 2024 · 0 comments · May be fixed by #579
Open

proto-plus >= 1.25 needed for python 3.13 #571

parthea opened this issue Oct 25, 2024 · 0 comments · May be fixed by #579
Assignees
@daniel-sanche
Labels
api: datastore Issues related to the googleapis/python-datastore API.

Comments

@parthea
Copy link
Contributor

parthea commented Oct 25, 2024

The setup.py file should be updated to require proto-plus >= 1.25 for python_version >=3.13 due to googleapis/proto-plus-python#490

See release notes here: https://github.com/googleapis/proto-plus-python/releases/tag/v1.25.0

Add "proto-plus >= 1.25.0, <2.0.0dev; python_version>='3.13'", after the following line

python-datastore/setup.py

Line 38 in 3e4133e

"proto-plus >= 1.22.2, <2.0.0dev; python_version>='3.11'",

As an example, see googleapis/python-api-core#740
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Oct 25, 2024
daniel-sanche added a commit that referenced this issue Dec 16, 2024
@daniel-sanche
chore: update protoplus for python 3.13
920760e 
Fixes #571
@daniel-sanche daniel-sanche linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: datastore Issues related to the googleapis/python-datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update protoplus for python 3.13 googleapis/python-datastore
2 participants
@daniel-sanche @parthea