-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Address queries not fully satisfying requested offset #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwilcox
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Mar 31, 2020
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Mar 31, 2020
Test Added. Not really confirming the case. Will need to further flesh out.
|
crwilcox
changed the title
fix: datastore client not properly respecting limits and offsets.
WIP: fix: datastore client not properly respecting limits and offsets.
Apr 2, 2020
crwilcox
force-pushed
the
large_offsets
branch
2 times, most recently
from
April 6, 2020 21:31
76817ee
to
992d8ad
Compare
crwilcox
changed the title
WIP: fix: datastore client not properly respecting limits and offsets.
fix: datastore client not properly respecting limits and offsets.
Apr 6, 2020
crwilcox
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Apr 6, 2020
crwilcox
changed the title
fix: datastore client not properly respecting limits and offsets.
fix: datastore client not properly respecting limits and offsets
Apr 6, 2020
crwilcox
changed the title
fix: datastore client not properly respecting limits and offsets
fix: Address queries not fully satisfying requested offset
Apr 6, 2020
10 tests fail both with and without my changes
|
busunkim96
approved these changes
Apr 6, 2020
crwilcox
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 7, 2020
Update: after refreshing test dataset, all tests are passing. |
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 7, 2020
Bypassing kokoro. Only failures are lint and docs. On areas not touched by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, submitting tests to run on CI
Currently Failing Test: https://github.com/googleapis/python-datastore/pull/18/files#diff-8a7c6f378fc6b49d53199fcf42bcfe0fR518
Related to #20