Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests.unit.test_arrow: test_series_from_arrow[time-nanoseconds-arrow-from-string] failed #120

Closed
flaky-bot bot opened this issue Jun 14, 2022 · 5 comments · Fixed by #148
Closed
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. external This issue is blocked on a bug with the actual product. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 14, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: 0a3cb48
buildURL: Build Status, Sponge
status: failed

Test output
pyarrow_array = 
[
  00:00:00.000000000,
  12:30:15.123456789,
  23:59:59.999999999
]
expected = 0           00:00:00
1    12:30:14.998902
2    23:59:58.999272
dtype: dbtime
@pytest.mark.parametrize(
    ["expected", "pyarrow_array"],
    SERIES_ARRAYS_DEFAULT_TYPES + SERIES_ARRAYS_CUSTOM_ARROW_TYPES,
)
def test_series_from_arrow(pyarrow_array: pyarrow.Array, expected: pandas.Series):
    # Convert to RecordBatch because types_mapper argument is ignored when
    # using a pyarrow.Array. https://issues.apache.org/jira/browse/ARROW-9664
    record_batch = pyarrow.RecordBatch.from_arrays([pyarrow_array], ["test_col"])
    dataframe = record_batch.to_pandas(date_as_object=False, types_mapper=types_mapper)
    series = dataframe["test_col"]
  pandas.testing.assert_series_equal(series, expected, check_names=False)

tests/unit/test_arrow.py:272:


.nox/unit_prerelease/lib/python3.10/site-packages/pandas/_testing/asserters.py:851: in assert_extension_array_equal
_testing.assert_almost_equal(
pandas/_libs/testing.pyx:52: in pandas._libs.testing.assert_almost_equal
???


???
E AssertionError: ExtensionArray are different
E
E ExtensionArray values are different (66.66667 %)
E [index]: [0, 1, 2]
E [left]: [00:00:00, 12:30:15.123456, 23:59:59.999999]
E [right]: [00:00:00, 12:30:14.998902, 23:59:58.999272]

pandas/_libs/testing.pyx:167: AssertionError

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 14, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Jun 14, 2022
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Jun 16, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (0a3cb48), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

1 similar comment
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (0a3cb48), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 21, 2022
@meredithslota meredithslota added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. labels Jun 28, 2022
@parthea
Copy link
Contributor

parthea commented Aug 6, 2022

Closing as obsolete

@parthea parthea closed this as completed Aug 6, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Aug 6, 2022

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 508564f
buildURL: Build Status, Sponge
status: failed

Test output
pyarrow_array = 
[
  00:00:00.000000000,
  12:30:15.123456789,
  23:59:59.999999999
]
expected = 0           00:00:00
1    12:30:14.998902
2    23:59:58.999272
dtype: dbtime
@pytest.mark.parametrize(
    ["expected", "pyarrow_array"],
    SERIES_ARRAYS_DEFAULT_TYPES + SERIES_ARRAYS_CUSTOM_ARROW_TYPES,
)
def test_series_from_arrow(pyarrow_array: pyarrow.Array, expected: pandas.Series):
    # Convert to RecordBatch because types_mapper argument is ignored when
    # using a pyarrow.Array. https://issues.apache.org/jira/browse/ARROW-9664
    record_batch = pyarrow.RecordBatch.from_arrays([pyarrow_array], ["test_col"])
    dataframe = record_batch.to_pandas(date_as_object=False, types_mapper=types_mapper)
    series = dataframe["test_col"]
  pandas.testing.assert_series_equal(series, expected, check_names=False)

tests/unit/test_arrow.py:272:


.nox/unit_prerelease/lib/python3.10/site-packages/pandas/_testing/asserters.py:852: in assert_extension_array_equal
_testing.assert_almost_equal(
pandas/_libs/testing.pyx:52: in pandas._libs.testing.assert_almost_equal
???


???
E AssertionError: ExtensionArray are different
E
E ExtensionArray values are different (66.66667 %)
E [index]: [0, 1, 2]
E [left]: [00:00:00, 12:30:15.123456, 23:59:59.999999]
E [right]: [00:00:00, 12:30:14.998902, 23:59:58.999272]

pandas/_libs/testing.pyx:167: AssertionError

@flaky-bot flaky-bot bot reopened this Aug 6, 2022
@chalmerlowe
Copy link
Collaborator

Based on conversation in the pandas github issue tracker, the root cause of these failing tests appears to be that the pandas system is trying to store too large a number in an int32 memory location. The bug has been added to the pandas 1.5 milestone (pandas is currently at 1.5.0 release candidate stage)

See:
pandas-dev/pandas#48255

@chalmerlowe chalmerlowe added the external This issue is blocked on a bug with the actual product. label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. external This issue is blocked on a bug with the actual product. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants