Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid out-of-range nanoseconds field in pandas 1.5.x #148

Merged
merged 1 commit into from
Sep 19, 2022
Merged

fix: avoid out-of-range nanoseconds field in pandas 1.5.x #148

merged 1 commit into from
Sep 19, 2022

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Sep 16, 2022 •
edited
Loading

Using out-of-range nanoseconds in pandas is deprecated (pandas-dev/pandas#48538) and broken in pandas 1.5 (pandas-dev/pandas#48255).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #133
Fixes #132
Fixes #121
Fixes #120
Fixes #119
Fixes #118
Fixes #117
🦕

@tswast tswast requested a review from a team as a code owner September 16, 2022 16:21
@tswast tswast requested review from a team and Neenu1995 September 16, 2022 16:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Sep 16, 2022
@tswast tswast mentioned this pull request Sep 16, 2022
Closed
3 tasks
@chalmerlowe
Copy link
Collaborator

LGTM.

chalmerlowe
chalmerlowe approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swast for submitting this.

@chalmerlowe chalmerlowe merged commit 2a477ca into main Sep 19, 2022
@chalmerlowe chalmerlowe deleted the issue133-timestamp-constructor branch September 19, 2022 15:21
@release-please release-please bot mentioned this pull request Sep 19, 2022
Merged
This was referenced Sep 28, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
2 participants
@tswast @chalmerlowe