-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: use pandas.NaT
for missing values in dbdate and dbtime dtypes
#67
Conversation
This makes them consistent with other date/time dtypes, as well as internally consistent with the advertised `dtype.na_value`. BREAKING-CHANGE: dbdate and dbtime dtypes return NaT instead of None for missing values Release-As: 0.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear how/why this gets used in practice. Is this an attempt at exposing typed nulls in the pandas space?
Numpy/Pandas have a special case for date/time arrays. The underlying c-buffer is of integers, rather than floating point values, so NaN can't be stored. Instead they pick a date/time that's unlikely to be used and add lots of checks throughout the code so that it behaves mostly like a NaN would. Some new Pandas types also have a |
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2022-03-24) ### ⚠ BREAKING CHANGES * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * * fix: address failing compliance tests in DateArray and TimeArray * dbdate and dbtime dtypes return NaT instead of None for missing values ### Features * dbdate and dbtime support numpy.datetime64 values in array constructor ([1db1357](1db1357)) ### Bug Fixes * address failing 2D array compliance tests in DateArray ([#64](#64)) ([b771e05](b771e05)) * address failing tests with pandas 1.5.0 ([#82](#82)) ([38ac28d](38ac28d)) * allow comparison with scalar values ([#88](#88)) ([7495698](7495698)) * avoid TypeError when using sorted search ([#84](#84)) ([42bc2d9](42bc2d9)) * correct TypeError and comparison issues discovered in DateArray compliance tests ([#79](#79)) ([1e979cf](1e979cf)) * dbdate and dbtime support set item with null values ([#85](#85)) ([1db1357](1db1357)) * use `pandas.NaT` for missing values in dbdate and dbtime dtypes ([#67](#67)) ([f903c2c](f903c2c)) * use public pandas APIs where possible ([#60](#60)) ([e9d41d1](e9d41d1)) ### Tests * add dbtime compliance tests ([#90](#90)) ([f14fb2b](f14fb2b)) * add final dbdate compliance tests and sort ([#89](#89)) ([efe7e6d](efe7e6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This makes them consistent with other date/time dtypes, as well as internally
consistent with the advertised
dtype.na_value
.BREAKING-CHANGE: dbdate and dbtime dtypes return NaT instead of None for missing values
Release-As: 0.4.0
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #66
🦕