Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(client): Fix typo in get_mtls_endpoint_and_cert_source doc #672

Closed
wants to merge 1 commit into from
Closed

docs(client): Fix typo in get_mtls_endpoint_and_cert_source doc #672

wants to merge 1 commit into from

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Dec 28, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea Just a typo fix, not necessary IMO
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@rwhogg rwhogg requested review from a team as code owners December 28, 2022 14:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Dec 28, 2022
parthea
parthea requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated. Please open a PR in gapic-generator-python

https://github.com/googleapis/gapic-generator-python/blob/4baf5923889750f950c26ad36c65869ec3ec2718/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L233

https://github.com/googleapis/gapic-generator-python/blob/4baf5923889750f950c26ad36c65869ec3ec2718/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/async_client.py.j2#L116

@rwhogg rwhogg mentioned this pull request Jan 4, 2023
Merged
4 tasks
@rwhogg
Copy link
Contributor Author

rwhogg commented Jan 4, 2023

I opened a PR in the other repo, so closing this PR

@rwhogg rwhogg closed this Jan 4, 2023
@rwhogg rwhogg deleted the typo branch January 4, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea requested changes

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwhogg @parthea