Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Release Notes: Add crypto_key_path_path to crypto_key_path #43

Closed
dylancaponi opened this issue Aug 26, 2020 · 2 comments · Fixed by #45
Closed

Release Notes: Add crypto_key_path_path to crypto_key_path #43

dylancaponi opened this issue Aug 26, 2020 · 2 comments · Fixed by #45
Assignees
@yoshi-automation
Labels
api: cloudkms Issues related to the googleapis/python-kms API. type: docs Improvement to the documentation for an API.

Comments

@dylancaponi
Copy link

dylancaponi commented Aug 26, 2020 •
edited
Loading

The snippets were modified to show crypto_key_path_path changed to crypto_key_path here: 8068e87

It was mentioned in an older synth.py but that TODO was removed:

python-kms/synth.py

Line 49 in fa794ff

# TODO: remove when this library is moved to the microgenerator and mention it in the relase

However, there is no mention or the crypto_key_path_path change in 2.0.0 Migration Guide.

Please consider adding it.

Thanks!
@product-auto-label product-auto-label bot added the api: cloudkms Issues related to the googleapis/python-kms API. label Aug 26, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Aug 27, 2020
@busunkim96 busunkim96 added the type: docs Improvement to the documentation for an API. label Aug 27, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Aug 27, 2020
busunkim96 added a commit that referenced this issue Aug 27, 2020
@busunkim96
docs: add crypto_key_path_path method rename to UPGRADING.md
13fbe61 
Closes #43
@busunkim96 busunkim96 mentioned this issue Aug 27, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 31, 2020
@busunkim96
docs: add crypto_key_path_path method rename to UPGRADING.md (#45)
81db5d9 
Closes #43
@symbiont-ji
Copy link

The documentation: https://googleapis.dev/python/cloudkms/latest/_modules/google/cloud/kms_v1/gapic/key_management_service_client.html#KeyManagementServiceClient.crypto_key_path_path still mentions crypto_key_path_path. Is it that hard to keep docs and library in sync?

@busunkim96
Copy link
Contributor

Hi @symbiont-ji,

We have an issue where old pages stick around in the /latest/ alias. However, there is no link or search query that would lead you to that page if you start from https://googleapis.dev/python/cloudkms/latest/kms_v1

https://googleapis.dev/python/cloudkms/latest/search.html?q=crypto_key_path

@ozer550 ozer550 mentioned this issue Apr 11, 2023
Merged
24 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yoshi-automation yoshi-automation

Labels
api: cloudkms Issues related to the googleapis/python-kms API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add crypto_key_path_path method rename to UPGRADING.md googleapis/python-kms
4 participants
@dylancaponi @busunkim96 @yoshi-automation @symbiont-ji