-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update tests to support latest google-cloud-core #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
tswast
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Sep 23, 2020
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 23, 2020
product-auto-label
bot
added
the
api: logging
Issues related to the googleapis/python-logging API.
label
Sep 24, 2020
tswast
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Oct 5, 2020
tseaver
approved these changes
Oct 6, 2020
Python 3.6 systest failure due to #64. |
…-logging into google-cloud-core-1.4.2rc1
tseaver
approved these changes
Oct 6, 2020
daniel-sanche
added a commit
that referenced
this pull request
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: logging
Issues related to the googleapis/python-logging API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google-cloud-core
version 1.4.2 populatesprettyPrint=false
bydefault. Update the connection tests to expect a value for
prettyPrint
.This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.
Closes: #64.