Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update tests to support latest google-cloud-core #66

Closed
wants to merge 7 commits into from

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Sep 23, 2020

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.

Closes: #64.

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Sep 24, 2020
@tswast tswast requested a review from a team as a code owner September 29, 2020 19:48
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@tseaver
Copy link
Contributor

tseaver commented Oct 6, 2020

Python 3.6 systest failure due to #64.

daniel-sanche added a commit that referenced this pull request Oct 15, 2020
@daniel-sanche
Copy link
Contributor

Thanks Tim! I was actually working on a separate PR to fix this and other failing tests here. Since we can't merge this PR until the other fixes are in, I pulled your changes over there, and I'll close this one. Let me know if you have any other suggestions in #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update system test PubSub calls or change PubSub deps
3 participants