Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: batch at most 1,000 ack ids per request #802

Merged
merged 4 commits into from
Oct 8, 2022
Merged

fix: batch at most 1,000 ack ids per request #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be73324
fix: batch at most 1,000 ack ids per request
beltran Oct 8, 2022
369ed9d
Merge branch 'main' into fix_1000
acocuzzo Oct 8, 2022
dbb15f4
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 8, 2022
5860a7d
Merge branch 'main' into fix_1000
acocuzzo Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions google/cloud/pubsub_v1/subscriber/_protocol/dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,8 @@
"""The maximum amount of time in seconds to wait for additional request items
before processing the next batch of requests."""

_ACK_IDS_BATCH_SIZE = 2500
_ACK_IDS_BATCH_SIZE = 1000
"""The maximum number of ACK IDs to send in a single StreamingPullRequest.

The backend imposes a maximum request size limit of 524288 bytes (512 KiB) per
acknowledge / modifyAckDeadline request. ACK IDs have a maximum size of 164
bytes, thus we cannot send more than o 524288/176 ~= 2979 ACK IDs in a single
StreamingPullRequest message.

Accounting for some overhead, we should thus only send a maximum of 2500 ACK
IDs at a time.
"""

_MIN_EXACTLY_ONCE_DELIVERY_ACK_MODACK_RETRY_DURATION_SECS = 1
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/pubsub_v1/subscriber/test_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ def test_ack_splitting_large_payload():
dispatcher_.ack(items)

calls = manager.send_unary_ack.call_args_list
assert len(calls) == 3
assert len(calls) == 6

all_ack_ids = {item.ack_id for item in items}
sent_ack_ids = collections.Counter()
Expand Down Expand Up @@ -689,7 +689,7 @@ def test_modify_ack_deadline_splitting_large_payload():
dispatcher_.modify_ack_deadline(items)

calls = manager.send_unary_modack.call_args_list
assert len(calls) == 3
assert len(calls) == 6

all_ack_ids = {item.ack_id for item in items}
sent_ack_ids = collections.Counter()
Expand Down