-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Stage 3-4 of nox
implementation - adding auto-format targets
#478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Aug 31, 2020
mf2199
added
api: spanner
Issues related to the googleapis/python-spanner-django API.
type: process
A process-related concern. May include testing, release, or the like.
labels
Aug 31, 2020
c24t
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only issue I see is black/isort incompatibility, but that's only an issue for people (like me) running isort locally since we don't call it from nox. Let me try to reconcile this with #469.
c24t
approved these changes
Aug 31, 2020
c24t
pushed a commit
that referenced
this pull request
Sep 15, 2020
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner-django API.
cla: yes
This human has signed the Contributor License Agreement.
type: process
A process-related concern. May include testing, release, or the like.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #466 , this represents item 4 of the recommended list aimed to implement nox testing automation in multiple steps.
Change list:
lint
andblacken
added to the Nox configuration;blacken
routines;As multiple Python versions already present in
unit
session, no separate PR for item 3 is necessary at this point.The
lint
session has conflicting definitions amongflake8
andblacken
(the latter follows PEP8). This is a known error, discussed, for example, here and here. The fix involves adding exceptions to theflake8
configuration file.Session log:
Towards #474.