Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not comply with E203 from pep8 #315

Closed
horta opened this issue Jun 7, 2018 · 3 comments
Closed

Does not comply with E203 from pep8 #315

horta opened this issue Jun 7, 2018 · 3 comments

Comments

@horta
Copy link

horta commented Jun 7, 2018

Operating system:
Python version: 3.6
Black version: 18.6b1
Does also happen on master: yes

Create a file with

tup = nsamples, nalleless[i : i + size], i, size

and black won't correct the white spaces around :.
@JelleZijlstra
Copy link
Collaborator

pep8 is wrong here. Quoting black's README: "This behaviour may raise E203 whitespace before ':' warnings in style guide enforcement tools like Flake8. Since E203 is not PEP 8 compliant, you should tell Flake8 to ignore these warnings."

In general when using black it's safe to disable formatting-related errors in tools like flake8; black takes care of the styling minutiae for you.

@horta
Copy link
Author

horta commented Jun 7, 2018

Thanks a lot, @JelleZijlstra !

@zsol zsol closed this as completed Jun 7, 2018
@goern goern mentioned this issue Dec 14, 2018
Merged
ggoossen added a commit to ggoossen/pytorch that referenced this issue Jan 2, 2019
@ggoossen @facebook-github-bot
Ignore flake8 warning about whitespace before ':'
f3e04f4 
Summary:
Ignore sometimes incorrect flake8 warning about whitespace before ':'

See psf/black#315

Differential Revision: D13565818

fbshipit-source-id: ce3ff158da2e4443e44f01c86dcbd889c9f5bcc1
@ggoossen ggoossen mentioned this issue Jan 2, 2019
Closed
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this issue Jan 3, 2019
@ggoossen @facebook-github-bot
Ignore flake8 warning about whitespace before ':' (#15663)
10c10b0 
Summary:
Pull Request resolved: #15663

Ignore sometimes incorrect flake8 warning about whitespace before ':'

See psf/black#315

Reviewed By: soumith

Differential Revision: D13565818

fbshipit-source-id: 9d5ec2335899527ee71f4b505c00865a354e3bf0
@maxandersen maxandersen mentioned this issue Jan 12, 2019
Merged
@shagren shagren mentioned this issue Feb 8, 2019
Merged
@sileht sileht mentioned this issue Jul 10, 2019
Merged
m3nu added a commit to m3nu/invoice2data that referenced this issue Aug 21, 2019
@m3nu
Ignore E203. See psf/black#315
2fb23cd
m3nu added a commit to invoice-x/invoice2data that referenced this issue Aug 21, 2019
@m3nu
Format with Black. (#247)
056b5ee 
* Format with Black.
* Ignore E203. See psf/black#315
@tucosaurus tucosaurus mentioned this issue Sep 25, 2019
Merged
@marco-c marco-c mentioned this issue Oct 21, 2019
Merged
ramyaragupathy added a commit to hotosm/tasking-manager that referenced this issue Oct 23, 2019
@ramyaragupathy
Ignore E203 psf/black#315
590db92
ramyaragupathy added a commit to hotosm/tasking-manager that referenced this issue Oct 23, 2019
@ramyaragupathy
Ignore E203 psf/black#315
88ce069
ramyaragupathy pushed a commit to hotosm/tasking-manager that referenced this issue Oct 23, 2019
@ramyaragupathy
Add teams and organisations backend
e99862f 
Complete teams and organisations, extend campaigns from tags into own objects

Port teams, orgs and campaigns to APIv2

Cleaning up and debugging teams, orgs and campaigns backend

fix revision for merge

Handle non-null fields + Consistent table names

CI fix: Update Image ID

Black formatting

Flake updates

Flake fix

Remove the default length

Ignore E203 psf/black#315

Revert ignore flag on flake
@uhbif19 uhbif19 mentioned this issue Nov 20, 2019
Closed
@davidlatwe davidlatwe mentioned this issue Jan 8, 2020
Closed
wuxiaohua1011 added a commit to wuxiaohua1011/maggma that referenced this issue Jan 22, 2020
@wuxiaohua1011
flake8 is disabled because the following issue when committing cannot…
ef1368c 
… be resolved. Following the suggestion on this thread:

psf/black#315
@mschmidt87 mschmidt87 mentioned this issue Mar 20, 2020
Merged
@choucavalier choucavalier mentioned this issue Apr 19, 2020
Closed
coobas pushed a commit to coobas/yoyo-migrations that referenced this issue May 9, 2020
@ollyc
tox: fix pytest command name and add E203 exception for flake8
0c23306 
E203 isn't PEP8 compliant - see psf/black#315
@alexander-held alexander-held mentioned this issue May 20, 2020
Closed
agucova added a commit to agucova/BC_API that referenced this issue Jun 2, 2020
@agucova
Adjust flake8 settings
d66d49a 
E203 was removed per PEP 8, and line length was changed to 88.

See psf/black#315
jonathanhaigh added a commit to jonathanhaigh/multiconfparse that referenced this issue Jun 5, 2020
@jonathanhaigh
Ignore flake8 errors incompatible with PEP8
705c285 
* E203: See psf/black#315
* W503: See psf/black#21
jonathanhaigh added a commit to jonathanhaigh/multiconfparse that referenced this issue Jun 5, 2020
@jonathanhaigh
Ignore flake8 errors incompatible with PEP8
f2e4673 
* E203: See psf/black#315
* W503: See psf/black#21
@jonathanhaigh jonathanhaigh mentioned this issue Jun 5, 2020
Merged
jonathanhaigh added a commit to jonathanhaigh/multiconfparse that referenced this issue Jun 5, 2020
@jonathanhaigh
Ignore flake8 errors incompatible with PEP8 (#32)
b94767f 
* E203: See psf/black#315
* W503: See psf/black#21
@akash-suresh akash-suresh mentioned this issue Jun 9, 2020
Merged
3 tasks
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Jul 24, 2023
@pwnfan
infra.misc>modify.fix: ignore E203 in flake8, see psf/black#315 for d…
8c8736a 
…etails
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Jul 24, 2023
@pwnfan
infra.misc>modify.fix: ignore E203 in flake8, see psf/black#315 for d…
a6c3f53 
…etails
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Jul 24, 2023
@pwnfan
infra.misc>modify.fix: ignore E203 in flake8, see psf/black#315 for d…
ed994bc 
…etails
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Aug 3, 2023
@pwnfan
infra.ci>modify.fix> fix ci lint error for PEP8 E203, see infra.misc>…
2c467e6 
…modify.fix: ignore E203 in flake8, see psf/black#315 for details
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Aug 3, 2023
@pwnfan
infra.ci>modify.fix> fix ci lint error for PEP8 E203, see infra.misc>…
e8298c6 
…modify.fix: ignore E203 in flake8, see psf/black#315 for details
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Aug 3, 2023
@pwnfan
infra.ci>modify.fix> fix ci lint error for PEP8 E203, see infra.misc>…
55a377d 
…modify.fix: ignore E203 in flake8, see psf/black#315 for details
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Aug 3, 2023
@pwnfan
infra.ci>modify.fix> fix ci lint error for PEP8 E203, see infra.misc>…
be816f6 
…modify.fix: ignore E203 in flake8, see psf/black#315 for details
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Aug 3, 2023
@pwnfan
infra.ci>modify.fix> fix ci lint error for PEP8 E203, see infra.misc>…
61b1596 
…modify.fix: ignore E203 in flake8, see psf/black#315 for details
pwnfan added a commit to pwnfan/tagmark-py that referenced this issue Aug 4, 2023
@pwnfan
infra.ci>modify.fix> fix ci lint error for PEP8 E203, see infra.misc>…
37e4232 
…modify.fix: ignore E203 in flake8, see psf/black#315 for details
@jtwaleson jtwaleson mentioned this issue Sep 3, 2023
Closed
4 tasks
mmalina added a commit to konflux-ci/release-service-utils that referenced this issue Nov 10, 2023
@mmalina
fix: flake8 and black conflict
caec652 
Flake8 was disagreeing with a formatting change
black did. It turns out this is a known issue
and it seems the recommended solution is to ignore
this warning in flake8.

See here for more details:
psf/black#315

Signed-off-by: Martin Malina <mmalina@redhat.com>
mmalina added a commit to konflux-ci/release-service-utils that referenced this issue Nov 10, 2023
@mmalina
refactor(RHTAPBUGS-919): create components in batches (#92)
875ff0b 
* refactor(RHTAPBUGS-919): create components in batches

By creating sbom components in Pyxis in batches
of 5, the overall script runtime is reduced by around
47 % in my testing with an sbom with 113 components.

The batch size is configurable, but currently set to 5.

* fix: flake8 and black conflict

Flake8 was disagreeing with a formatting change
black did. It turns out this is a known issue
and it seems the recommended solution is to ignore
this warning in flake8.

See here for more details:
psf/black#315

Signed-off-by: Martin Malina <mmalina@redhat.com>
TOP-10-DEV added a commit to TOP-10-DEV/localGPT that referenced this issue Dec 8, 2023
@TOP-10-DEV
Update .flake8 to ignore E203
c00ded5 
This conflicts with black. Black converts `arr[start:end]` to `arr[start : end]`. .flake8 fails because it expects that there are not spaces before `:`
Here is the source
psf/black#315
@Alrobbertz Alrobbertz mentioned this issue Dec 21, 2023
Closed
@dbarrous dbarrous mentioned this issue Jan 29, 2024
Merged
pieqq added a commit to canonical/checkbox that referenced this issue Apr 10, 2024
@pieqq
Ignore E203 (Whitespace before ':')
487d3db 
As explained in this issue[1], E203[2] is not PEP 8 compliant so it
should be ignored when running flake8.

Black is now being used in the codebase, and it takes care of the
formatting.

[1] psf/black#315
[2] https://www.flake8rules.com/rules/E203.html
pieqq added a commit to canonical/checkbox that referenced this issue Apr 11, 2024
@pieqq
Ignore E203 (Whitespace before ':')
5951fab 
As explained in this issue[1], E203[2] is not PEP 8 compliant so it
should be ignored when running flake8.

Black is now being used in the codebase, and it takes care of the
formatting.

[1] psf/black#315
[2] https://www.flake8rules.com/rules/E203.html
pieqq added a commit to canonical/checkbox that referenced this issue Apr 11, 2024
@pieqq
Ignore E203 (Whitespace before ':')
6736ce7 
As explained in this issue[1], E203[2] is not PEP 8 compliant so it
should be ignored when running flake8.

Black is now being used in the codebase, and it takes care of the
formatting.

[1] psf/black#315
[2] https://www.flake8rules.com/rules/E203.html
pieqq added a commit to canonical/checkbox that referenced this issue Apr 11, 2024
@pieqq
Code formatting using black (infra) (#1163)
3789fdd 
* Set line length to 79 when calling black

black uses pyproject.toml to store its configuration. Update the
different projects in the monorepo to match line length of 79 when
calling black.

See black documentation[1] for more information.

[1]
https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

* Update contributing guide to mention black

* Add black GitHub Action

* Ignore vendorized code when running black

* Format all the codebase using black

Command used:

    black . --line-length 79 --extend-exclude "/vendor/"


* Ignore E203 (Whitespace before ':')

As explained in this issue[1], E203[2] is not PEP 8 compliant so it
should be ignored when running flake8.

Black is now being used in the codebase, and it takes care of the
formatting.

[1] psf/black#315
[2] https://www.flake8rules.com/rules/E203.html

* Ignore flake8 complaints for a few specific lines in the base provider

Although Black is configured at 79 chars line length, it keeps a few
lines to 80, 81 or 82 chars. Flake8 will complain about this, but we can
ignore these.
LiaoU3 pushed a commit to LiaoU3/checkbox that referenced this issue Apr 17, 2024
@pieqq @LiaoU3
Code formatting using black (infra) (canonical#1163)
7269845 
* Set line length to 79 when calling black

black uses pyproject.toml to store its configuration. Update the
different projects in the monorepo to match line length of 79 when
calling black.

See black documentation[1] for more information.

[1]
https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-via-a-file

* Update contributing guide to mention black

* Add black GitHub Action

* Ignore vendorized code when running black

* Format all the codebase using black

Command used:

    black . --line-length 79 --extend-exclude "/vendor/"

* Ignore E203 (Whitespace before ':')

As explained in this issue[1], E203[2] is not PEP 8 compliant so it
should be ignored when running flake8.

Black is now being used in the codebase, and it takes care of the
formatting.

[1] psf/black#315
[2] https://www.flake8rules.com/rules/E203.html

* Ignore flake8 complaints for a few specific lines in the base provider

Although Black is configured at 79 chars line length, it keeps a few
lines to 80, 81 or 82 chars. Flake8 will complain about this, but we can
ignore these.
@jonnydh jonnydh mentioned this issue May 1, 2024
Merged
@surchs surchs mentioned this issue May 6, 2024
Open
JonasDoesThings added a commit to JonasDoesThings/mkdocs-exclude-unused-files that referenced this issue Jun 9, 2024
@JonasDoesThings
style: exclude E203 from flake8 (see psf/black#315)
a13fc8d
@cedricdcc cedricdcc mentioned this issue Jul 10, 2024
Merged
VeckoTheGecko added a commit to OceanParcels/Parcels that referenced this issue Jul 23, 2024
@VeckoTheGecko
Disable linting error E203
f248416 
psf/black#315
ngullotta added a commit to ngullotta/QuantiPy that referenced this issue Sep 25, 2024
@ngullotta
Ignore E203
e8335d6 
See psf/black#315
bsquizz added a commit to bsquizz/tangerine-backend that referenced this issue Nov 20, 2024
@bsquizz
Add flake8 ignore for E203 (see psf/black#315)
b092423
bsquizz added a commit to RedHatInsights/tangerine-backend that referenced this issue Nov 21, 2024
@bsquizz
Add document chunks to vector store in batches (#82)
83c5084 
* Add flake8 ignore for E203 (see psf/black#315)

* Use batch size when adding documents to avoid embedding API overload

* Move to python 3.12

* Use itertools.batched

* Update .python-version

* Fix SyntaxWarning

* Print batch number correctly
spicydilly added a commit to spicydilly/advent-of-code-2024 that referenced this issue Dec 3, 2024
@spicydilly
e203 does not coply with pep8 as per psf/black#315
bc6d4fc
spicydilly added a commit to spicydilly/advent-of-code-2024 that referenced this issue Dec 3, 2024
@spicydilly
Add day 1 - 3 solutions (#1)
30bdf87 
* e203 does not coply with pep8 as per psf/black#315

* add basic setup

* add 3 days of solutions

* add pre commit validation and test

* update python
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zsol @horta @JelleZijlstra @svenevs