Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iexact lookup with Transform expression crash issue when RHS is direct value and a transform function is involved #628

Merged
merged 12 commits into from
May 20, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented May 20, 2021

In iexact match added a check, If rhs is not a direct value and parameter is not present we want to have only 1 format able argument in rhs_sql else we need 2.

this is fix for queries like:Author.objects.filter(name__upper__iexact="abc").

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner May 20, 2021 05:41
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label May 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

django: iexact lookup with Transform expression crashes
2 participants