-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update docs and nox file to compile it #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add a Code of Conduct (googleapis#604)
fix: lint_setup_py was failing in Kokoro is now fixed (googleapis#607)
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/python-spanner-django API.
label
Apr 22, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 22, 2021
vi3k6i5
changed the title
feat: Nox file fix
feat: Docs added and Nox file updated to compile it
Apr 22, 2021
vi3k6i5
force-pushed
the
nox_file_fix
branch
4 times, most recently
from
April 22, 2021 15:24
526bc00
to
1570343
Compare
larkee
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nit: PR title should be in present tense (e.g. update docs and nox file)
vi3k6i5
changed the title
feat: Docs added and Nox file updated to compile it
feat: update docs and nox file to compile it
Apr 24, 2021
fix: Remove un necessary file from code base (googleapis#608)
feat: move migrations test modules to run against different emulator …
feat: update workflow files to uniformly distribute the test modules …
vi3k6i5
force-pushed
the
nox_file_fix
branch
2 times, most recently
from
April 28, 2021 14:51
4f050c8
to
21e28a2
Compare
vi3k6i5
added a commit
to vi3k6i5/python-spanner-django
that referenced
this pull request
Apr 28, 2021
feat: update docs and nox file to compile it (googleapis#610)
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner-django API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Docs files added and Nox file updated to compile it.