-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Docstrings for django_spanner
#564
Merged
Merged
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
e264a94
docs for base
tina80lvl 5069132
docs for client
tina80lvl ca9c7ce
docs for compiler
tina80lvl 1a6257a
docs for expressions
tina80lvl cfdba5f
docs for features
tina80lvl 2b742f8
docs for functions
tina80lvl a82bf1b
docs for introspection
tina80lvl b819547
resolving conflict
tina80lvl 321858f
docs for lookups
tina80lvl e77b4e9
docs for operations
tina80lvl 4db2d4a
docs for schema
tina80lvl 115881f
docs for utils
tina80lvl 0647468
docs: updates to `base.py`
mf2199 6970b97
docs: updates to `client.py`
mf2199 8dab421
docs for validation
tina80lvl 04a0cac
docs: updates to `complier.py`
mf2199 c2a09f0
Merge branch 'docstr-2' of https://github.com/q-logic/python-spanner-…
mf2199 0d2ec73
docs: updates to `creation.py`
mf2199 3a6e84a
docs: updates to `expressions.py`
mf2199 1479a2f
docs: updates to `features.py`
mf2199 c902cd2
docs: updates to `functions.py`
mf2199 6cfb4a5
docs: updates to `introspection.py`
mf2199 5580621
docs: updates to `lookups.py`
mf2199 7deb3d3
docs: updates to `operations.py`
mf2199 ed86c06
Merge branch 'master' into docstr-2
c24t 67106fa
fix: docstrings
mf2199 c9364d0
fix: typo
mf2199 678ecb3
fix: docstrings
mf2199 0b84fb6
fix: single quotes
tina80lvl 583398d
fix: docstrings typing
tina80lvl 2afc4eb
Remove runshell docstring
c24t d36b9ab
Remove some TODOs from docstrings
c24t 117484b
Merge branch 'master' into docstr-2
c24t 5240d21
Fix operations docstrings
c24t 499c61a
Merge branch 'master' into docstr-2
mf2199 d749356
docs: docstrings
mf2199 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear that we could implement this since cloud spanner doesn't have a "shell" executable. We might want to consider https://github.com/cloudspannerecosystem/spanner-cli or a similar project for this in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the docstring here, just raising
NotSupportedError
is fine since spanner doesn't really give us a way to support this.