Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add description for transaction autocommit #587

Merged
merged 1 commit into from
Jan 29, 2021
Merged

fix: add description for transaction autocommit #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions django_spanner/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,10 @@ def is_usable(self):

return True

# The usual way to start a transaction is to turn autocommit off.
# Spanner DB API does not properly start a transaction when disabling
# autocommit. To avoid this buggy behavior and to actually enter a new
# transaction, an explicit SELECT 1 is required.
def _start_transaction_under_autocommit(self):
"""
Start a transaction explicitly in autocommit mode.
Expand Down