Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct test case for sql_flush for multiple delete table commands #629

Merged
merged 38 commits into from
May 20, 2021
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ad001a8
feat: updated nox file for docs and docfx and added unit tests for cl…
vi3k6i5 Apr 6, 2021
17aa057
Merge branch 'master' into unit_tests
vi3k6i5 Apr 6, 2021
924f1ee
Merge pull request #1 from googleapis/master
vi3k6i5 Apr 6, 2021
df919be
fix: lint_setup_py was failing in Kokoro is not fixed
vi3k6i5 Apr 6, 2021
2bc42b0
feat: updated nox file for docs and docfx and added unit tests for cl…
vi3k6i5 Apr 6, 2021
cd3951c
feat: added docfx build in nox file
vi3k6i5 Apr 7, 2021
0de5617
feat: added docfx build in nox file
vi3k6i5 Apr 7, 2021
d8e2864
feat: added docfx build in nox file
vi3k6i5 Apr 7, 2021
00e2ee8
Merge branch 'unit_tests' of github.com:vi3k6i5/python-spanner-django…
vi3k6i5 Apr 7, 2021
ad5f15c
Merge pull request #2 from googleapis/master
vi3k6i5 Apr 7, 2021
ecb0eec
feat: updated nox file for docs and docfx and added unit tests for cl…
vi3k6i5 Apr 6, 2021
a816ab9
feat: added docfx build in nox file
vi3k6i5 Apr 7, 2021
798e88d
feat: fixed nox file conflict
vi3k6i5 Apr 7, 2021
ec28c1c
feat: adding unit tests for django spanner
vi3k6i5 Apr 21, 2021
5ec9841
Merge pull request #3 from googleapis/master
vi3k6i5 Apr 25, 2021
34c4dda
Merge pull request #4 from googleapis/master
vi3k6i5 Apr 27, 2021
caf5a43
Merge pull request #5 from googleapis/master
vi3k6i5 Apr 28, 2021
129e41e
Merge pull request #6 from googleapis/master
vi3k6i5 Apr 28, 2021
fad6cf3
feat: updated nox file for docs and docfx and added unit tests for cl…
vi3k6i5 Apr 6, 2021
cef35a5
feat: added docfx build in nox file
vi3k6i5 Apr 7, 2021
30a62ae
feat: updated nox file for docs and docfx and added unit tests for cl…
vi3k6i5 Apr 6, 2021
56bd658
feat: added docfx build in nox file
vi3k6i5 Apr 7, 2021
588ee4b
feat: updated nox file for docs and docfx and added unit tests for cl…
vi3k6i5 Apr 6, 2021
7fdc7dd
feat: adding unit tests for django spanner
vi3k6i5 Apr 21, 2021
2ee4870
bug: fixed schema tests settings to create instance and delete it aft…
vi3k6i5 Apr 30, 2021
cab2cc1
Merge branch 'unit_tests' of github.com:vi3k6i5/python-spanner-django…
vi3k6i5 Apr 30, 2021
8b69cc8
bug: test fixes for schema file
vi3k6i5 May 3, 2021
2bb3fff
feat: added unit test coverage for functions, introspection and schema
vi3k6i5 May 4, 2021
92c18ef
Merge branch 'master' of github.com:googleapis/python-spanner-django …
vi3k6i5 May 18, 2021
cfb532b
refactor: lint the code
vi3k6i5 May 18, 2021
7e41463
refactor: removed unrelated code from PR
vi3k6i5 May 18, 2021
18dc883
ci: added build for docfx and refactores settings for unit tests
vi3k6i5 May 18, 2021
09f69ef
build: added python 3.9 in setup file
vi3k6i5 May 18, 2021
06a397d
refactor: changed coverage check to 65 from 68 to be conservative in …
vi3k6i5 May 18, 2021
870494d
Merge branch 'master' into unit_test_cleanup
vi3k6i5 May 19, 2021
2257c34
Merge branch 'master' of github.com:googleapis/python-spanner-django …
vi3k6i5 May 20, 2021
8d34638
fix: corrected test case for sql_flush for multiple delete table comm…
vi3k6i5 May 20, 2021
d2500e7
Merge branch 'master' of github.com:googleapis/python-spanner-django …
vi3k6i5 May 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/django_spanner/test_operations.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ def test_sql_flush(self):

self.assertEqual(
self.db_operations.sql_flush(
style=no_style(), tables=["Table1, Table2"]
style=no_style(), tables=["Table1", "Table2"]
),
["DELETE FROM `Table1, Table2`"],
["DELETE FROM Table1", "DELETE FROM Table2"],
)

def test_sql_flush_empty_table_list(self):
Expand Down