-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable support for get_key_columns
and cleanup tests with unknown failures to specific failures.
#721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/python-spanner-django API.
label
Oct 11, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 11, 2021
vi3k6i5
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 12, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 12, 2021
vi3k6i5
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 12, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 12, 2021
vi3k6i5
changed the title
feat: enable support for foreign key and enable related tests.
feat: enable support for Oct 12, 2021
get_key_columns
and cleanup tests with unknown failures to specific failures.
asthamohta
reviewed
Oct 12, 2021
asthamohta
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vi3k6i5
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 13, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 13, 2021
vi3k6i5
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 13, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 13, 2021
This was referenced Apr 17, 2024
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner-django API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: enable support for
get_key_columns
and cleanup tests with unknown failures to specific failures.Note: ON DELETE CASCADE is not supported still for Foreign key, so this feature is not full fledged yet.