Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change datetime.now to utcnow #251

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #228 🦕

I think it's related to #244 issue so changed datetime.now() to datetime.utcnow()

@HemangChothani HemangChothani requested a review from tseaver August 20, 2020 07:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 20, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Aug 21, 2020
@frankyn frankyn requested a review from andrewsg August 24, 2020 21:11
@frankyn frankyn added the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3465d08 into googleapis:master Aug 25, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Fixes googleapis#228  🦕

I think it's related to googleapis#244 issue so changed datetime.now() to datetime.utcnow()
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Fixes googleapis#228  🦕

I think it's related to googleapis#244 issue so changed datetime.now() to datetime.utcnow()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'test_get_signed_policy_v4' flakes with 500
3 participants